From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3643 invoked by alias); 15 Mar 2018 21:58:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3048 invoked by uid 89); 15 Mar 2018 21:58:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Mar 2018 21:58:12 +0000 Received: from ESESSHC022.ericsson.se (Unknown_Domain [153.88.183.84]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 40.E4.02394.07CEAAA5; Thu, 15 Mar 2018 22:58:09 +0100 (CET) Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSHC022.ericsson.se (153.88.183.84) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 15 Mar 2018 22:58:08 +0100 Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Thu, 15 Mar 2018 22:58:07 +0100 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Thu, 15 Mar 2018 22:58:07 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.61.117] (192.75.88.130) by MW2PR1501MB2010.namprd15.prod.outlook.com (2603:10b6:302:c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.14; Thu, 15 Mar 2018 21:58:03 +0000 Subject: Re: [PATCH 2/3] Testsuite: Rename "end()" to avoid libinproctrace C++ symbol clash To: Andreas Arnez , References: <1521043903-18837-1-git-send-email-arnez@linux.vnet.ibm.com> <1521043903-18837-3-git-send-email-arnez@linux.vnet.ibm.com> From: Simon Marchi Message-ID: <5431d374-f1a4-65e0-82ee-a1758aa037a1@ericsson.com> Date: Thu, 15 Mar 2018 21:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1521043903-18837-3-git-send-email-arnez@linux.vnet.ibm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR21CA0003.namprd21.prod.outlook.com (2603:10b6:404:8e::13) To MW2PR1501MB2010.namprd15.prod.outlook.com (2603:10b6:302:c::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c7e13cae-8293-46e3-7ebf-08d58abfd3d6 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:MW2PR1501MB2010; X-Microsoft-Exchange-Diagnostics: 1;MW2PR1501MB2010;3:low5sbcVX7ae2htkhKZLImgd0f2azxDnV3mMlczNGOYa8nTacQill8EHZ4oou25cr8288JjgREOZ2nT7GrJXChJ7cMiL/OL7ALG+7Ma9V2JdDvw0kKLgOltjyBuxGKUfjSj5Bjs9LHsvSU10i7XeZCLwHQOD0ay3IIddKZxjzTDQ5MrTwMh3tFRkm2ZXFeoCQ1dgCs3GtisvxYQWokM0L3gclUjIXbdx20fkC5Vo7R9oS2YwgwnilBm8cLKCsNTw;25:l66nNlJBCUp5xbIlhwX2Pb+RFH0Etx8x6TTCw/zblsQBLOvJ2uXIbpFORujs9SNBF6Or/wbgLyMwPI5txcz9fq+TMCjY1P240v+VlFj68e6kwPqU+Rs9+00qcQJWkl7OOB0EimXWqKbQD2jo6EraVkfHSgdUUtw2WYKC36HNzCaWrYYs5vLciNk0KsDvSUnGquybFzLO9gDnHOaVba024A5LatfDlRqK8WokjHnVSclYz4q9yMnyUJhvj9PQFP+HDbZVAx49StT03T279CdW1kcAqM0GcgysZDgaYBCcpkpyGOR8qnyQi+57Qumlwvy89hIIWPLwLu+qbs8v9SMGDQ==;31:oGoXmD9546n+J+n9t8cuGxarzvoZFRn52T+I1tK1+k1HWjKe/NjyvxZyVFujsRBfwJrWbuHNdYSMoph9ZQpBaYTE76xmVIf7js9AQXmR4/B5JSw3MubkA64gi/VTGRo9vyhgTsTrUWexIx3usoVMOanEoyzedihA+2ma1Mm0UJriG93YJ+9idwgYeQVywQ4xDURjBjaB0fg9KqirAB7pUAaZ/ujHlyoby+vw3AtXHqc= X-MS-TrafficTypeDiagnostic: MW2PR1501MB2010: X-Microsoft-Exchange-Diagnostics: 1;MW2PR1501MB2010;20:QuuvNAgtYKwmokmXu+Gwa0HqroFqjtmGx1pT2RPHlssblvtPNy2QveYEFZqZFvlNhcjvNMyT7xBoGZeRqsaZ3HTffnS20X+p/8blS0Svp/ngDZWB6+bdhgD1nAfSsZBqgzqcdnuxv7wPM4oicNKuJ0KNqswhkjf9fqhnc34jinJix8WhvDqCh+gkg+X2+2FqeAFQ+JTieI7+emTQGqzWX0rkr5/VZmvsFM+2zSIxg6OmquBF5DHS898pptoAGL1VU0dDhElSKTk4D+Esxd9lYcS+WNHFq0vyK3sZBpm8RzeeCIlfewIEc4qaJwAdveb1oYkkVifotpv9TvW97Ak5wECyEFnnFtFsbtnOxLca3xPbAPB8kYk8ycxpxp5+zPigXGkfc3UdMR61ULojaA4djoWpj5Axs3Vib5uGqYVa02jkmuj2rKO1lbtPMPIQ+3AuZ5AoTp3TLhoXiKH2rL577x/XCHOSK/mYpwf5n470Eh/opAGVeFPCCieBPozSLSiy;4:wLxPda+WPon8DT58roMUxQSbV58ZcmUapHu8aNLYM6/gq8FJ9bx6MFs/WFAmf1dMH1r/Mj2bsw4KxpJxQvrGCbtKJM2oChBZQ4CbHKoEVACHZ9Ao0E/9S69VpB2q9h1pui/GYlz8sPFq/5KUGguj7PiAASoYSj2B19pk3ByGL9uZ8HmKIimySNvvPu434IWFYkezgZ9+bkRhrsnhk5poJVGh8mjPY2ZGCO9vdngRPWsSJlys5cf6gEX8h4aMtvBgxwvM442mBUIITKoxmbpn7g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501244)(52105095)(3002001)(10201501046)(6041310)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:MW2PR1501MB2010;BCL:0;PCL:0;RULEID:;SRVR:MW2PR1501MB2010; X-Forefront-PRVS: 0612E553B4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(366004)(39380400002)(39860400002)(346002)(396003)(376002)(199004)(189003)(54534003)(377424004)(81166006)(65826007)(7736002)(65956001)(66066001)(76176011)(53546011)(8676002)(386003)(106356001)(31696002)(47776003)(305945005)(6486002)(2906002)(26005)(52116002)(49976009)(23676004)(52146003)(16526019)(2486003)(5660300001)(316002)(25786009)(6116002)(97736004)(478600001)(16576012)(81156014)(8936002)(65806001)(186003)(3846002)(86362001)(230700001)(36756003)(229853002)(2950100002)(68736007)(105586002)(31686004)(6666003)(53936002)(50466002)(64126003)(58126008)(6246003)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:MW2PR1501MB2010;H:[142.133.61.117];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNVzJQUjE1MDFNQjIwMTA7MjM6bXN0RHZrRjBwWUl4UWx3V3QxQjdUMnRS?= =?utf-8?B?b1V6b1pLNG16TksvUUkwQ2sxbFJTbVROSXN6VlpoN25qaG1wTmN0ZUpQejJK?= =?utf-8?B?TENYYWN6bXlxbzdRZVkwTlg2b0JQYzQydXBqTUlPMVRzRUpwWnRrTmU3aWNz?= =?utf-8?B?WVhEdWFES0lxUno2WVhnck1LZnNvYkRqci9FWTR0NFZRbWNzcFBOMStPNHhR?= =?utf-8?B?Z3BJZTY0dGJLUHB0dnR4Y0orUHlMMUxPR0hVcThSOHB5blVRZUhzcDU3SDVL?= =?utf-8?B?QWx4QmZ1RmR3NWhxS3ZLRFZLZEp0Qk9NVmVmNTBudnZ2ZlhnczZjVnZEM1dE?= =?utf-8?B?dlFZNVdDTTUrcU44MTVjMCtTSmpPWklsbGNFcHlUd1R1REx5cm5lTUxUeWpu?= =?utf-8?B?Y1ZsTm81Vi9ZUmlHRjlrejc0SnByd2FrTENMRjZuSWlKMVp4ZUlwNW1YUWpD?= =?utf-8?B?Zy9kV3Z4Z2JLcDB5MzBrb25MTHpEUnNmYmd3Q3BDaXBYR0t1RTVXbjBnU3Bo?= =?utf-8?B?dWdFYUpJcEZTdExEU0llVmtmb1NUQmdDQ0tYRXBta0kwT0dXN2EzcmN2Z2NY?= =?utf-8?B?YnhBcWRvQ3FxVjRmUnZpZTVHYWhjaC83aFRNNldpMkVUMFRxaEl0aWQ5Y1Ew?= =?utf-8?B?N011L2lFWC9rK0gzSXFtTUM2TVpqZ3RoaEJSbXd3N01UMzJ0Smk5QlYvV0hT?= =?utf-8?B?ckJLeFY3c2FuNVpncHRkck5CUVBEaElLeUoxMDZlOXJhcUtXZG1ZM1hlamVJ?= =?utf-8?B?djlXL3h4dGo4ZkIzUW1WR3hDT1l2UTdBNHcvMDNsU2JRbmI0djlZNUNrbnBI?= =?utf-8?B?WmtDaFM2Qm1oMzFZeGpyTTd3Skw3ZFBiS3A2R0JacHV6S3pjamhiRy9uMXVM?= =?utf-8?B?SHp2QlBFci9xb2huQkdXdEhxQ3U1S050WXNEZExLM3hPVFpmWUg2TVYyK0E2?= =?utf-8?B?djdrc00wOC9sSE81d2tac3JHVGgzM2ZhemRsZTJLTW53OUdGaWNMRjl5S2NH?= =?utf-8?B?VTR3YjBrTEpWRHZWd3hMQkRvV0g3dTFmS0c4eXR1QVRpQ3FDazk0cm9xdmV2?= =?utf-8?B?ZkswZXJrM1MxdVJ4SER6eGFsMGt3dkkwRGRXT1pkL1VwRnVyVmt1V1NhNHlK?= =?utf-8?B?ZktKWFBCTmlzMURNRmlTanpoTGw5VENEdkUraS9QK1Z5QzZwbFBNTHZ3czlT?= =?utf-8?B?RGVtcUc1SGluVGJpVDVocFNRYXBDeUlWZG9yMVJrUGtOZ3BldGlwREJVSURo?= =?utf-8?B?TFhlSDFURGpjbmswbm9JT21wOWtjb2pSY1czb0hCZVhONG5JMWhtWklYMVpw?= =?utf-8?B?SWcrUUVCWGlXMUdVM1NzWUhTZVJORUlVbVJrdVVTWTVzazlIRGNoblFnOGs0?= =?utf-8?B?bDdvMmhRU3pPUGhiTDA5SkV6WVdWYURCdXBTSkpIbjdyZzk5dlEwazdJQndJ?= =?utf-8?B?b1JIOGRSKzN3UlRaREZ6UkdHYWtlTzhXU0FnbnJhLy9YQzlYdmlaQ0FMWG9Z?= =?utf-8?B?SXhaRnFXMFMwQ0dhbEZOVndYL0I0V0dBdy9aVDVhdWFINjNGOHBjZG93Ukgy?= =?utf-8?B?dkNrLzNFQVl2OStTY2phTG92SzVrZXUvOWhWWEpMY3J5c01VdU8veHdkVWg4?= =?utf-8?B?RkVoT2V6bUNKZTFQZ2VrMFlaVXdjeXdMMWN6NVYyUVd5OFNyblU3UndMaW9w?= =?utf-8?B?SEdnNStFcFkwNGMxZUNhMlpIZHhTN21PaWF5UlF6SytPaW9vNHQzZ3lDUk9J?= =?utf-8?B?Ny9Wa2xmQXBVOUhUMHdNY2g0ci9sNEw2R2V3VnNXYWxjeTlDb21lN0JyTzQx?= =?utf-8?B?UUsvSHBhT3RKaE9JbFg2SHBCWnRCUEhjN2I1anQzZXY0RUtPQT09?= X-Microsoft-Antispam-Message-Info: 7TnyTg5ciU2LpCKPRaLRxKCw38u4MZkPnd4ngCdRHowXK01kbOy+i65+o4Qvb1cy3mPRuAL+t13fIwmJ3zVImkn8tE62jcYQTJ3EpRjSP3nBbiLC+KEi3/Z9Ba5ljdg4DyZhiTGuLMwjwI9ZVZ5Suqikx84nRwIhHYuVRcBSRVENXbBATLkqfyBOP8N3+FJ2 X-Microsoft-Exchange-Diagnostics: 1;MW2PR1501MB2010;6:BOilc5h73AFkLLugGTjA2e6CRbPrMoIDD6R3akXyOZg1EMxCpPjUBM1F+YgANYzaPSA/bEqL4FR/q15BmJmVH/XclxG+wyKjZ0r6WGexkQJ7vAC74tDfjMUVr1E234W5lhF+6zNicdwL5vbCuJLaDIpuaGAW0kcbpoinVKKKBrvCBnBaWfYmHMGZRVyRaDDCDY0nS83oetCUuJnbzYSUE9mbfPeewaacIWG66sIHIp7CFN4Y8q4MMGrlPDSgPg779mQ0AhJBwso8jzx5A6iKqfdz5qpGL2zmNeD9z81SHl3Ax5Zba179OSXEZOS1JbYLe4BLjBQ8WuTr7SUbLGM7XHMifvqEP781t3RMVycIDIA=;5:/oE4/Pzs6TK+HgoIih6qP5siU6JPIBlxJNRC9q8wmnL6CCmpaaECqRqz+yEd/NWmXa17xM65FT9mDUwOsltYwnLS8sV2muwdAYSCnJ9tvVPGLBLoezonR85pIZBPLPKIr4ykl+LxbEbdJxRHROSaM3gw9MmxxDpIiy4y2Hec2AE=;24:fAzgTDTYK0J6JfIywGbQZUxHA7b4/D77+voFHoTlUJkWHa+fPnWTnefFf6o9wdlV1zcq/yaSjKyaOLoRc6jmqVgMKoGKEQ4sh3ImqpG95L8=;7:nfo4mGEt2wHE/WR3atDfH91qqgrssWk7LK3ri6eR9MuLH++8bxCZjx7CTAT32J3Q5rW24l3cTS+hxYiS1Z5DuwP1FZ7ezgbLSpeRCbYQ2a/ZR0qeeyUMvScX6q8ThkezNJSpg9lbDEAowQ1u5zeVvfmPh+bxD3NcgPsCFTqWPi7aFZfh9WOiImnZ1ViQc5hTYAYrpJdGYGnv6QYz88LQorhn4mW+hg3n1qzdLIZuoCCNOXE0enOrCCssR7lCZh1K SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2018 21:58:03.5385 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7e13cae-8293-46e3-7ebf-08d58abfd3d6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR1501MB2010 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00311.txt.bz2 On 2018-03-14 12:11 PM, Andreas Arnez wrote: > Some of GDB's trace test cases define a function end() and place a > breakpoint there with "break end". However, when libinproctrace is linked > to the binary, there are multiple methods named "end", such as > std::string::end() from the C++ library or format_pieces::end() from > common/format.h. GDB then creates multiple breakpoints instead of just a > single one, and some FAILs result, such as these: > > FAIL: gdb.trace/trace-mt.exp: ftrace on: break end > FAIL: gdb.trace/trace-mt.exp: ftrace off: break end > > This is fixed by renaming end() to my_end(). For consistency, where end() > was paired with a previous begin(), the latter is renamed to my_begin() as > well. > > gdb/testsuite/ChangeLog: > > * gdb.trace/trace-break.c (end): Rename to... > (my_end): ...this. > (main): Adjust call. > * gdb.trace/trace-mt.c (end): Rename to... > (my_end): ...this. > (main): Adjust call. > * gdb.trace/unavailable.cc (begin): Rename to... > (my_begin): ...this. > (end): Rename to... > (my_end): ...this. > (main): Adjust calls. > * gdb.trace/trace-break.exp: Reflect function name change. > * gdb.trace/trace-mt.exp: Likewise. > * gdb.trace/unavailable.exp: Likewise. Hi Andreas, Another way would have been to pass "-qualified" to the break command, or use gdb_breakpoint and pass the "qualified" arg. There are also other instances of the same "problem" in tests that don't check the output of the break command at all... gdb_test "break end" ".*" "" In any case, this patch LGTM. Thanks, Simon