From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5ABF73858439 for ; Thu, 4 Nov 2021 18:43:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5ABF73858439 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1A4IhE1F028575 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 4 Nov 2021 14:43:18 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1A4IhE1F028575 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 072841ECEB; Thu, 4 Nov 2021 14:43:13 -0400 (EDT) Message-ID: <543b67d0-07de-13db-5f73-0f74cc315174@polymtl.ca> Date: Thu, 4 Nov 2021 14:43:13 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: gdb: disable -Wmissing-prototypes warning w/gcc Content-Language: en-US To: Andrew Burgess , Simon Marchi , gdb-patches@sourceware.org References: <20200303223442.330-1-simon.marchi@efficios.com> <20211104121716.GE918204@redhat.com> <32f7539b-55e6-80c4-0032-a41532eeb933@polymtl.ca> From: Simon Marchi In-Reply-To: <32f7539b-55e6-80c4-0032-a41532eeb933@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 4 Nov 2021 18:43:14 +0000 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2021 18:43:23 -0000 > Just wondering, does anybody care about building GDB with a compiler > other than GCC and Clang? Because another way that excludes the warning > just for gcc (rather than include it for anything that isn't gcc) would > be (in pseudo code): > > diff --git a/gdbsupport/warning.m4 b/gdbsupport/warning.m4 > index 46036fa461e8..33a729a60d5d 100644 > --- a/gdbsupport/warning.m4 > +++ b/gdbsupport/warning.m4 > @@ -150,7 +150,7 @@ then > [WARN_CFLAGS="${WARN_CFLAGS} $w"], > [] > ) > - else > + elif (compiler is not gcc) or (warning is not -Wmissing-prototypes); then > AC_COMPILE_IFELSE( > [AC_LANG_PROGRAM([], [])], > [WARN_CFLAGS="${WARN_CFLAGS} $w"], > > If that works, I think it would be preferable, but otherwise I think > your patch is OK. Please push whatever makes the most sense to you, so > we can finally get rid of this warning :). > > Simon > Hmm, actually using $GCC doesn't work: it gets set to yes even when building with clang. I think it means more "does the compiler supports the GNU extension", which the clang compiler supports, for the most part. And the goal is to have -Wmissing-prototypes when building with clang. Simon