From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20161 invoked by alias); 24 Oct 2014 18:45:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20149 invoked by uid 89); 24 Oct 2014 18:45:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Oct 2014 18:45:56 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Xhjs0-0007E3-OD from Don_Breazeal@mentor.com ; Fri, 24 Oct 2014 11:45:52 -0700 Received: from [127.0.0.1] ([172.30.14.126]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 24 Oct 2014 11:45:52 -0700 Message-ID: <544A9E5F.5010701@codesourcery.com> Date: Fri, 24 Oct 2014 18:45:00 -0000 From: "Breazeal, Don" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 02/16 v2] Refactor follow-fork message printing References: <1407434395-19089-1-git-send-email-donb@codesourcery.com> <1408580964-27916-3-git-send-email-donb@codesourcery.com> <5425C3E4.3060305@redhat.com> <5425C92B.1010101@codesourcery.com> <543E9C0F.9030701@redhat.com> <544841F0.7000604@codesourcery.com> <544A4789.6020500@redhat.com> In-Reply-To: <544A4789.6020500@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00668.txt.bz2 On 10/24/2014 5:35 AM, Pedro Alves wrote: > On 10/23/2014 12:46 AM, Breazeal, Don wrote: >> On 10/15/2014 9:08 AM, Pedro Alves wrote: >>>> On 09/26/2014 09:14 PM, Breazeal, Don wrote: >>>>>> On 9/26/2014 12:52 PM, Pedro Alves wrote: >>>>>>>> On 08/21/2014 01:29 AM, Don Breazeal wrote: >>>>>>>>>> This patch refactors the code that prints messages related to follow-fork >> ---snip--- >> >>>> Sorry, I still don't think you're new patch (sent as follow up) is >>>> an improvement... Having to explain the "Hardcoded 1's" in a >>>> comment is a red sign to me. :-/ >> Fair enough. >> >>>> >>>> Could you do a patch that just adds the missing output, and fixes >>>> fork/vfork without moving the printing code to a separate function? >>>> For the fork vs vfork issue, doing ' is_vfork ? "vfork" : "fork" ' is >>>> fine. >> Thanks for clarifying the i18n issues for me. The revised patch is >> included below, with an updated commit message as well. Is this version OK? > > Yes, thanks! > > Pedro Alves > Thanks, this is pushed in. --Don