From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4368 invoked by alias); 29 Oct 2014 09:13:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4357 invoked by uid 89); 29 Oct 2014 09:13:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Oct 2014 09:13:28 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9T9DM1G009735 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 29 Oct 2014 05:13:23 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9T9DIPF007310; Wed, 29 Oct 2014 05:13:19 -0400 Message-ID: <5450AFAE.6080701@redhat.com> Date: Wed, 29 Oct 2014 09:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Yao Qi , Victor Kamensky CC: gdb-patches@sourceware.org, Andrew Pinski Subject: Re: [RFC PATCH 2/2] fix py-value-cc.exp test for big endian target References: <1414379778-5478-1-git-send-email-victor.kamensky@linaro.org> <1414379778-5478-3-git-send-email-victor.kamensky@linaro.org> <87oasvtmax.fsf@codesourcery.com> In-Reply-To: <87oasvtmax.fsf@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00792.txt.bz2 On 10/29/2014 06:36 AM, Yao Qi wrote: > Victor Kamensky writes: > >> The reason is that test case is not endian agnostic. >> Test program variable 'u' has type of 'union U { int a; >> char c; };'. Test program writes 99 into u.a and expects to see >> it in field 'u.c'. But it would only work on little endian >> system where 'c' field of U union conicide with least >> significant byte of 'a' field. ... >> U u; >> - u.a = 99; >> + u.a = 0x55000055; /* c is the same for big and little endian */ > > I'd like c is shown differently on big endian and little endian, and > check c's value in different endianness. It can be something like, > > u.a = 0x55000056 or u.a = 0x55565758 I noticed that the proposed changes assume all supported architectures have sizeof (int) == 4, but that's not valid assumption. E.g.,: (gdb) set architecture m68hc11 The target architecture is assumed to be m68hc11 (gdb) p sizeof (int) $1 = 2 (gdb) set architecture h8300 The target architecture is assumed to be h8300 (gdb) p sizeof (int) $2 = 2 (gdb) set architecture m32c The target architecture is assumed to be m32c (gdb) p sizeof (int) $3 = 2 (gdb) set architecture avr The target architecture is assumed to be avr (gdb) p sizeof (int) $4 = 2 etc. Maybe the simplest is to make the unions use uint32_t instead of int. Thanks, Pedro Alves