From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18091 invoked by alias); 5 Nov 2014 20:47:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18080 invoked by uid 89); 5 Nov 2014 20:47:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 05 Nov 2014 20:47:09 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA5Kl7bO011022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 5 Nov 2014 15:47:07 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sA5Kl5h6015425; Wed, 5 Nov 2014 15:47:06 -0500 Message-ID: <545A8CC9.601@redhat.com> Date: Wed, 05 Nov 2014 20:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org Subject: Re: [PATCH 08/12] btrace: identify cpu References: <1405346196-1804-1-git-send-email-markus.t.metzger@intel.com> <1405346196-1804-9-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1405346196-1804-9-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-11/txt/msg00108.txt.bz2 On 07/14/2014 02:56 PM, Markus Metzger wrote: > diff --git a/gdb/common/btrace-common.c b/gdb/common/btrace-common.c > index 90774a2..178ad35 100644 > --- a/gdb/common/btrace-common.c > +++ b/gdb/common/btrace-common.c > @@ -18,10 +18,47 @@ > along with this program. If not, see . */ > > #include "btrace-common.h" > +#include "nat/i386-cpuid.h" Hm, this is a layering violation. common/ files must not include nat/ files. If btrace-common.c is only used by native code, then it should itself be in nat/ too. Thanks, Pedro Alves