public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 00/12] record btrace: prepare for a new trace format
Date: Wed, 05 Nov 2014 20:50:00 -0000	[thread overview]
Message-ID: <545A8D84.5020201@redhat.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B231E659B63@IRSMSX104.ger.corp.intel.com>

On 10/28/2014 02:34 PM, Metzger, Markus T wrote:
> Hello Pedro, Maintainers,
> 
> Any feedback to this series?

Thanks, and sorry for the delay...

I read 1-11, and skimmed 12; will leave that one for when
you actually submit it.

This all looks reasonable, and the patches look
very well written to me.  Kudos.  I just spotted a few
minor issues which I pointed out as replies to the patches.
Patches that I didn't reply to were ones I didn't fell like
I had anything useful to say.

Thanks,
Pedro Alves

  reply	other threads:[~2014-11-05 20:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 13:56 Markus Metzger
2014-07-14 13:56 ` [PATCH 06/12] btrace: update btrace_compute_ftrace parameters Markus Metzger
2014-07-14 13:56 ` [PATCH 09/12] btrace: use the new cpu identifier Markus Metzger
2014-07-14 13:56 ` [PATCH 08/12] btrace: identify cpu Markus Metzger
2014-11-05 20:47   ` Pedro Alves
2014-07-14 13:56 ` [PATCH 02/12] btrace: add format argument to supports_btrace Markus Metzger
2014-11-05 20:45   ` Pedro Alves
2014-11-14 12:36     ` Metzger, Markus T
2014-11-14 13:36       ` Pedro Alves
2014-11-14 13:47         ` Metzger, Markus T
2014-11-14 13:50           ` Metzger, Markus T
2014-11-14 13:50           ` Pedro Alves
2014-07-14 13:57 ` [PATCH 04/12] record btrace: add configuration struct Markus Metzger
2014-07-14 15:06   ` Eli Zaretskii
2014-11-05 20:45   ` Pedro Alves
2014-07-14 13:57 ` [PATCH 11/12] configure: check for libipt Markus Metzger
2014-07-14 13:57 ` [PATCH 12/12] [wip] btrace: support Intel(R) Processor Trace Markus Metzger
2014-07-14 13:57 ` [PATCH 03/12] btrace, linux: add perf event buffer abstraction Markus Metzger
2014-07-14 13:57 ` [PATCH 07/12] btrace: extend struct btrace_insn Markus Metzger
2014-11-05 20:46   ` Pedro Alves
2014-07-14 13:57 ` [PATCH 10/12] record-btrace: indicate gaps Markus Metzger
2014-07-14 13:57 ` [PATCH 05/12] record-btrace: add bts buffer size configuration option Markus Metzger
2014-07-14 15:44   ` Eli Zaretskii
2014-11-05 20:46   ` Pedro Alves
2014-07-14 14:48 ` [PATCH 01/12] btrace: add struct btrace_data Markus Metzger
2014-11-05 20:44   ` Pedro Alves
2014-10-28 14:35 ` [PATCH 00/12] record btrace: prepare for a new trace format Metzger, Markus T
2014-11-05 20:50   ` Pedro Alves [this message]
2014-11-06  9:04     ` Metzger, Markus T
2014-11-07 11:27       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545A8D84.5020201@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).