From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31364 invoked by alias); 11 Nov 2014 16:43:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31353 invoked by uid 89); 11 Nov 2014 16:43:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 11 Nov 2014 16:43:22 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sABGhLFk016576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 11 Nov 2014 11:43:21 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sABGhJMh014235; Tue, 11 Nov 2014 11:43:20 -0500 Message-ID: <54623CA7.8060702@redhat.com> Date: Tue, 11 Nov 2014 16:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [PATCH v3 12/14] add linux_infcall_mmap References: <20141101214552.13230.45564.stgit@host1.jankratochvil.net> <20141101214719.13230.96367.stgit@host1.jankratochvil.net> In-Reply-To: <20141101214719.13230.96367.stgit@host1.jankratochvil.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-11/txt/msg00187.txt.bz2 On 11/01/2014 09:47 PM, Jan Kratochvil wrote: > +/* See gdbarch.sh 'infcall_mmap'. */ > + > +static CORE_ADDR > +linux_infcall_mmap (CORE_ADDR size, unsigned prot) > +{ > + struct objfile *objf; > + /* Do there still exist any Linux systems without "mmap64"? > + "mmap" uses 64-bit off_t on x86_64 and 32-bit off_t on i386 and x32. */ > + struct value *mmap_val = find_function_in_inferior ("mmap64", &objf); > + struct value *addr_val; > + struct gdbarch *gdbarch = get_objfile_arch (objf); > + CORE_ADDR retval; > + enum > + { > + ARG_ADDR, ARG_LENGTH, ARG_PROT, ARG_FLAGS, ARG_FD, ARG_OFFSET, ARG_MAX > + }; > + struct value *arg[ARG_MAX]; > + > + arg[ARG_ADDR] = value_from_pointer (builtin_type (gdbarch)->builtin_data_ptr, > + 0); > + /* Assuming sizeof (unsigned long) == sizeof (size_t). */ > + arg[ARG_LENGTH] = value_from_ulongest > + (builtin_type (gdbarch)->builtin_unsigned_long, size); > + gdb_assert ((prot & ~7) == 0); > + arg[ARG_PROT] = value_from_longest (builtin_type (gdbarch)->builtin_int, > + 0 > + | ((prot & 4) != 0 ? PROT_READ : 0) > + | ((prot & 2) != 0 ? PROT_WRITE : 0) > + | ((prot & 1) != 0 ? PROT_EXEC : 0)); > + arg[ARG_FLAGS] = value_from_longest (builtin_type (gdbarch)->builtin_int, > + MAP_PRIVATE | MAP_ANONYMOUS); PROT_READ, PROT_WRITE, PROT_EXEC, MAP_PRIVATE, MAP_ANONYMOUS are host values/macros. This needs to be made host independent, otherwise cross debugging to Linux passes the wrong values to mmap. It also likely breaks --enable-targets=all builds on hosts that don't have mmap at all. E.g., this comes out empty on F20: $ grep -rn PROT_READ /usr/i686-w64-mingw32/sys-root/mingw/include/ OTOH, the 4, 2 and 1 bits checked against the 'prot' argument are magical constants; they'd best be put behind macros, like e.g., GDB_MMAP_PROT_READ, etc., here and at the callers of gdbarch_infcall_mmap. Thanks, Pedro Alves