From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23747 invoked by alias); 13 Nov 2014 12:59:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23736 invoked by uid 89); 13 Nov 2014 12:59:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 13 Nov 2014 12:59:36 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sADCxXYa023700 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 13 Nov 2014 07:59:33 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sADCxVtK010220; Thu, 13 Nov 2014 07:59:32 -0500 Message-ID: <5464AB33.8090903@redhat.com> Date: Thu, 13 Nov 2014 12:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Don Breazeal , gdb-patches@sourceware.org Subject: Re: [PATCH 04/16 v3] Determine supported extended-remote features References: <1408580964-27916-1-git-send-email-donb@codesourcery.com> <1414798134-11536-2-git-send-email-donb@codesourcery.com> In-Reply-To: <1414798134-11536-2-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-11/txt/msg00256.txt.bz2 On 10/31/2014 11:28 PM, Don Breazeal wrote: > This patch implements a mechanism for GDB to determine what > extended-mode features are enabled in gdbserver. This is > a preparatory patch for extended-remote fork and exec event > support. > > Several new features are included in the potential response to > the qSupported packet, denoting fork, vfork, and exec events. > and exec events. Note that vfork_done events are not represented > here, because if vfork events are supported, gdbserver will fake > up a vfork_done event for GDB even if the target doesn't provide > direct support for vfork_done. > > A number of changes were required to make this work: > > 1) Sending the "!" (use extended protocol) packet before sending the > qSupported packet so that gdbserver knows it is in extended mode > when responding to qSupported. Previously qSupported was the > first packet sent. I don't think we should do this. What's wrong with always reporting support for the feature ? If GDB doesn't want them with "target remote", then it won't use them. If the server needs to know whether GDB supports or wants the feature before activating it, then GDB's qSupported query should indicate it. See the "multiprocess+" feature. As I mentioned before, I'd rather have fewer differences between "remote" and "extended-remote", not more. Thanks, Pedro Alves