From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4451 invoked by alias); 13 Nov 2014 18:59:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4442 invoked by uid 89); 13 Nov 2014 18:59:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 13 Nov 2014 18:59:14 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sADIxBxb013458 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 13 Nov 2014 13:59:11 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sADIx9su015875; Thu, 13 Nov 2014 13:59:10 -0500 Message-ID: <5464FF7D.6060103@redhat.com> Date: Thu, 13 Nov 2014 18:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: "Breazeal, Don" , gdb-patches@sourceware.org Subject: Re: [PATCH 06/16 v3] Extended-remote Linux follow fork References: <1408580964-27916-1-git-send-email-donb@codesourcery.com> <1414798134-11536-4-git-send-email-donb@codesourcery.com> <5464AB62.5040100@redhat.com> <5464FE11.1080001@codesourcery.com> In-Reply-To: <5464FE11.1080001@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-11/txt/msg00278.txt.bz2 On 11/13/2014 06:53 PM, Breazeal, Don wrote: > My initial approach was to do just that, but I ended up with > linux-specific code in remote.c (the code that lives in linux-nat.c > for the native implementation). I guess the direction of recent > changes would be to put that code into a common file in gdb/nat, > if possible. Would that be the approach you would recommend? I'm not seeing what would be linux-specific? On remote_follow_fork fork, we switch the current remote thread to gdb's current thread (either parent or child), by calling 'set_general_thread (inferior_ptid);' And then if we need to detach parent or child, we detach it with the D;PID packet. Thanks, Pedro Alves