From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18482 invoked by alias); 14 Nov 2014 13:36:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18471 invoked by uid 89); 14 Nov 2014 13:36:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 14 Nov 2014 13:36:51 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAEDalwK021882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 14 Nov 2014 08:36:48 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sAEDakHm000798; Fri, 14 Nov 2014 08:36:47 -0500 Message-ID: <5466056E.5060202@redhat.com> Date: Fri, 14 Nov 2014 13:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: "Metzger, Markus T" CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 02/12] btrace: add format argument to supports_btrace References: <1405346196-1804-1-git-send-email-markus.t.metzger@intel.com> <1405346196-1804-3-git-send-email-markus.t.metzger@intel.com> <545A8C5B.3040504@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-11/txt/msg00304.txt.bz2 On 11/14/2014 12:36 PM, Metzger, Markus T wrote: >> From: Pedro Alves [mailto:palves@redhat.com] >>> +/* Target specific branch trace information. */ >>> +struct btrace_target_info; >>> + >>> +/* Enumeration of btrace read types. */ >>> + >>> +enum btrace_read_type >>> +{ >>> + /* Send all available trace. */ >>> + BTRACE_READ_ALL, >>> + >>> + /* Send all available trace, if it changed. */ >>> + BTRACE_READ_NEW, >>> + >>> + /* Send the trace since the last request. This will fail if the trace >>> + buffer overflowed. */ >>> + BTRACE_READ_DELTA >>> +}; >> >> What does "Send" mean here? > > It means as much as "read". It determines what trace you'll get > when reading btrace. > I realize it's the producer's view; it should rather be the consumer's > view. Ah, yeah. > Do you want me to change it in a separate patch? Hmm, I'm confused -- why a separate patch instead of simply adjusting this one? Thanks, Pedro Alves