From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't enable gdbtk in testsuite
Date: Thu, 04 Dec 2014 17:07:00 -0000 [thread overview]
Message-ID: <548094B1.8050708@redhat.com> (raw)
In-Reply-To: <1416903049-30419-1-git-send-email-yao@codesourcery.com>
On 11/25/2014 08:10 AM, Yao Qi wrote:
> When I skim configure.ac and Makefile.in in gdb/testsuite, I happen to
> see that directory gdb.gdbtk is added to subdirs, however it doesn't
> exist. gdb/testsuite/gdb.gdbtk was removed by the patch below,
>
> [rfa] git repo fixup: delete gdb/testsuite/gdb.gdbtk
> http://thread.gmane.org/gmane.comp.gdb.patches/61489
That patch removed it from the git repo, mirroring how CVS modules
worked. In CVS, if you checkout the "gdb" module, you don't get
the gdbtk dirs, but if you checkout the insight module instead, you
get everything gdb, plus the insight bits: src/gdb/gdbtk subdir,
src/gdb/testsuite/gdb.gdbtk/, and maybe other bits.
So removing the testsuite support for gdbtk doesn't seem like
the right thing to do. Particularly since we still have the
gdbtk bits in gdb/configure.ac. IOW, I don't see how
src/gdb/testsuite/gdb.gdbtk/ not being around is different
from src/gdb/gdbtk/ not being around. We should either keep
all support for gdbtk, or remove all of it.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-12-04 17:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 8:11 Yao Qi
2014-11-30 15:23 ` Joel Brobecker
2014-12-01 6:15 ` Yao Qi
2014-12-04 17:07 ` Pedro Alves [this message]
2014-12-05 6:55 ` Yao Qi
2014-12-05 9:54 ` Pedro Alves
2014-12-05 10:05 ` Joel Brobecker
2014-12-05 12:04 ` Yao Qi
2014-12-05 11:27 Roland Schwingel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548094B1.8050708@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).