From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't enable gdbtk in testsuite
Date: Fri, 05 Dec 2014 09:54:00 -0000 [thread overview]
Message-ID: <548180B5.4060003@redhat.com> (raw)
In-Reply-To: <87y4qmd1qu.fsf@codesourcery.com>
On 12/05/2014 06:55 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> That patch removed it from the git repo, mirroring how CVS modules
>> worked. In CVS, if you checkout the "gdb" module, you don't get
>> the gdbtk dirs, but if you checkout the insight module instead, you
>> get everything gdb, plus the insight bits: src/gdb/gdbtk subdir,
>> src/gdb/testsuite/gdb.gdbtk/, and maybe other bits.
>
> Hi Pedro,
> I looked at insight and the date of the last commit in
> gdb/testsuite/ChangeLog is 2013-10-21. Looks insight stops updating gdb
> after gdb migrates to git so I think it should be safe to remove
> testsuite gdbtk from gdb head.
insight's official repo is kind of stuck in a limbo. CVS is dead,
so that's not where you should be looking. There's no official git
repo yet, but AIUI, people are using this non-official repo instead:
https://github.com/monnerat/insight
In any case, I don't see why we should treat insight bits in
gdb/testsuite/configure.ac any different from bits in gdb/configure.ac.
It's exactly the same issue.
>> So removing the testsuite support for gdbtk doesn't seem like
>> the right thing to do. Particularly since we still have the
>> gdbtk bits in gdb/configure.ac. IOW, I don't see how
>> src/gdb/testsuite/gdb.gdbtk/ not being around is different
>> from src/gdb/gdbtk/ not being around. We should either keep
>> all support for gdbtk, or remove all of it.
>
> It is aggressive to remove gdbtk bits from gdb/configure.ac, although
> there were some "insight end-of-life" discussions on insight mail list.
That topic was raised, but from those discussions it seemed clear
to me that there is still interest in it. E.g.,
https://sourceware.org/ml/insight/2014-q4/msg00007.html
https://sourceware.org/ml/insight/2014-q3/msg00010.html
Personally, I wouldn't be adverse to importing gdbtk into the official
gdb repo. I don't see how that could hurt -- we tend to worry
about insight anyway when we touch code that might affect it, like
most the deprecated_foo hooks.
> I am OK to revert my patch.
I think we should do that.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-12-05 9:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 8:11 Yao Qi
2014-11-30 15:23 ` Joel Brobecker
2014-12-01 6:15 ` Yao Qi
2014-12-04 17:07 ` Pedro Alves
2014-12-05 6:55 ` Yao Qi
2014-12-05 9:54 ` Pedro Alves [this message]
2014-12-05 10:05 ` Joel Brobecker
2014-12-05 12:04 ` Yao Qi
2014-12-05 11:27 Roland Schwingel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548180B5.4060003@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).