From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14109 invoked by alias); 8 Dec 2014 16:22:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14020 invoked by uid 89); 8 Dec 2014 16:22:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 08 Dec 2014 16:22:09 +0000 Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 47.DD.03307.5EF75845; Mon, 8 Dec 2014 11:39:34 +0100 (CET) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.90) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 8 Dec 2014 11:22:06 -0500 Message-ID: <5485D02D.1050202@ericsson.com> Date: Mon, 08 Dec 2014 16:22:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Keith Seitz CC: , Patrick Monnerat Subject: Re: [PATCH] Fix build with Python 3.4 (PR python/16784) References: <1417009634-2356-1-git-send-email-simon.marchi@ericsson.com> <5480A49F.1010904@redhat.com> <5482287D.9030500@ericsson.com> <87h9x9d7nf.fsf@redhat.com> <54823AA4.7080902@redhat.com> In-Reply-To: <54823AA4.7080902@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00178.txt.bz2 On 2014-12-05 06:07 PM, Keith Seitz wrote: > On 12/05/2014 03:00 PM, Sergio Durigan Junior wrote: >> On Friday, December 05 2014, Simon Marchi wrote: >> >>>>> I changed the signature of deprecated_readline_hook. I would've changed any >>>>> user of it, but it seems like nothing is using it, >>>> >>>> You'd probably find it in the insight/gdbtk code. >>> >>> Is this something that I need to update, or insight is not maintained anymore? >> >> Insight is maintained by Keith Seitz (Cc'ed in this message). My first >> reaction is that it would be good if you updated it. > > As reported elsewhere, Insight is a bit in limbo right now as I try to > figure out how to best deal with gdb moving to git (and start my own > migration). > > There is a temporary repository set up by the Fedora packaging > maintainer, Patrick Monnerat. I believe this was also referenced earlier. > > IMO, I would take that as the official repository for the time being. > > You can update it, or I can. It's not a huge deal; just let me know. (CCing Patrick Monnerat, see above for context) Here is the corresponding change in Insight (as expected very simple): https://github.com/simark/insight/commit/47810ab5fcbd528dc6b4422c93b5ecaccf2e4fe8 Since binutils-gdb is used as a submodule in the insight repo, this change should only be merged when the submodule is updated and includes the patch that changes the signature. Simon