From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2064.outbound.protection.outlook.com [40.107.105.64]) by sourceware.org (Postfix) with ESMTPS id 941B23858D20 for ; Wed, 9 Nov 2022 15:27:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 941B23858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XG9iS0ASU6LFSItSWA85LirLRV63hYcVm+sXi3oBrP28Sb91HVL7JqkYDXbgOydl3lCpU/cSwATNvYmpsSR2ka/P2TNUD0crKp0eO0AsvrNfVbuSBueC2XGW6ja/1ohrRZ67Nv4+iBSYJe39k0EfQ4Gd69IZdrGLoHg2PU4HAISATJ3w5k5kMXdrdqL4mLo6WXcoz52fryUUiHnblrTiK0Me31j4uEDetcPZtIo4yuPdt3WFw7oYx/jzyCb3ZiSnvf+lGlo+qf6wOAf//tPMbtVsOtdH1lygpu1B+8dCnA9PsheiCkarRW7Tx2DbCOVvEqKqHOZtKXrMxu5h72Qw7w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uN8xSMVX54V99bYU//KxcUpmilgu5OI8KoAeatmcwoY=; b=DiivpICmosE6X/fS+CFw5Kk9OVkRLhd+YqviPWY6Eoanod6usiwPWb4KUBu5U0dNlTTjW1RYKACE+VzoU8Pd40jIFtMXaBPsDhekfXsd3s0jCVYhH8BzJfXGflwbxXEMndreJaIqx/P5QV52fIJsZRo81eyTbS3T83yIRRu2o8mh7qN7oBpl9Q3z0RqQzjUbPo3eodVvihW1EqoWZfmn1xtPuR6mKVXLe2OLVvwxMcVgaZSeadSFfFDBec2ptlpsLXChaWi14teG4eQ/p4VMNifUd9JpBJAREyoXLcQFUOklurfnycS6vVehtDX6xKLC2pTMokBtsaAOO4CeTOkPFg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uN8xSMVX54V99bYU//KxcUpmilgu5OI8KoAeatmcwoY=; b=sNB+SJ3te7Mw7432UJ8h/f015pj5ReeFWE3v45kbhpUg839KGQE9Bd10u+qOYHxAevG40Tf/YINVohwWVVdzmy4NvNmlcjsoCslE0EFo1JX7SwfNxyEfUF/3+qe16Sh1EH6bYWhxOVEZdkoFWeWTXOjIoQz5tbqug2WBobExavU= Received: from DB7PR03CA0097.eurprd03.prod.outlook.com (2603:10a6:10:72::38) by AS8PR08MB6166.eurprd08.prod.outlook.com (2603:10a6:20b:296::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 15:27:44 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::8) by DB7PR03CA0097.outlook.office365.com (2603:10a6:10:72::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Wed, 9 Nov 2022 15:27:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 15:27:44 +0000 Received: ("Tessian outbound b4aebcc5bc64:v130"); Wed, 09 Nov 2022 15:27:44 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c29e618f65bebd13 X-CR-MTA-TID: 64aa7808 Received: from 19294b6353cd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8508F971-405F-4C03-B105-CB637836106C.1; Wed, 09 Nov 2022 15:27:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 19294b6353cd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Nov 2022 15:27:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WJR7st4STkQHUAqz6YtR24bydNCBxmucBCfAaokG6+iiPUEw3tigIhSpum3k4kq0jYW7VrmfAoKG2p5huiQDNI010QmbDXL1vKb6LNGnrlIIEZkhI6h832x77qAD6j6TOyLwqiajI2/lmuWm9uCniE1dBdineXYutmBqbfm2yfoRew658ZeWhpKZZABgdrOT/KJ4zFxFnC3sYZ2QiaU2gBjI0L+8ELj7IYQezQ6+wkgqb2Tb7R1uC80J7y0keqJFMaB3Jqn3Iggf6RWl0joiRRjTlIbFp01k7VqQ8HGtjLB49r1v+TmY9XMfKulWyqfyr8+b+MliWTuJwH+TzWWn2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uN8xSMVX54V99bYU//KxcUpmilgu5OI8KoAeatmcwoY=; b=TpVhTIW8z4aA1yAghu22evCrDO8uHiOQGT3zgk+s3q2kdywx/SJ1lZGsZlFd5Ij9EBBbAS5smKqqCiq/wnQE7s7N6I+POfUF1nnksZBxyUZRdbUrpjyA7x3PPFYH21MzcShC2PnaIlQJGHyP8IEhWT/V+YdW3e+GPiW6T27fXh9P9W4Lg+4Y0IOaPzIHdZCT1KDeVhs5jW3b3UY6MdigxZ0yxMEkvB361WTFAPP2WKONmEZSmFKrW6BNGSDRzf2+FSI6bq6wZFNWMoVTtkh4EJsEqllNomUpinVpONiUCttZK2b+pFcrxrjTQP/pbemUu7e5SG9C2JQTNn1VY9Va2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uN8xSMVX54V99bYU//KxcUpmilgu5OI8KoAeatmcwoY=; b=sNB+SJ3te7Mw7432UJ8h/f015pj5ReeFWE3v45kbhpUg839KGQE9Bd10u+qOYHxAevG40Tf/YINVohwWVVdzmy4NvNmlcjsoCslE0EFo1JX7SwfNxyEfUF/3+qe16Sh1EH6bYWhxOVEZdkoFWeWTXOjIoQz5tbqug2WBobExavU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB8276.eurprd08.prod.outlook.com (2603:10a6:20b:56e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Wed, 9 Nov 2022 15:27:30 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::f9e6:599b:e673:801]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::f9e6:599b:e673:801%5]) with mapi id 15.20.5813.012; Wed, 9 Nov 2022 15:27:30 +0000 Message-ID: <548988bd-5ccb-2982-296f-7eaa50328541@arm.com> Date: Wed, 9 Nov 2022 15:27:30 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [RFC PATCH 1/5] gdb/arm: Introduce control_s and control_ns registers Content-Language: en-US To: Tomas Vanek , gdb-patches@sourceware.org References: <1667641476-31602-1-git-send-email-vanekt@fbl.cz> <3d6331d0-d1b3-03f7-0b2c-97b0784fa31e@fbl.cz> <6bdb8d6d-c0f7-c154-c0a9-4897759fce91@fbl.cz> From: Luis Machado In-Reply-To: <6bdb8d6d-c0f7-c154-c0a9-4897759fce91@fbl.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0072.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::21) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB8276:EE_|DBAEUR03FT062:EE_|AS8PR08MB6166:EE_ X-MS-Office365-Filtering-Correlation-Id: eaa583d7-860e-4bb1-7868-08dac266f301 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: z0h20DJmRdT6K0CH+59APhPf+OnJOYfAayDZdR2Mh/7s9GoTXIGWJ/CpjZLTF/i+UXzbdS8kQMSxmOFGFEyj5M6x+y9yH5VLIRPMzo3UdERzWqUzmGEEeA+NTNZUlbNN9Jrd99e8ZTs8+LRlKPWoNRc+0yHOOMhcK+TC9TBcoVz3syGrqiy4AFaQvAt1QB3vXc0a1Fi5MWCIH6x642YEz9u/0VMyc0yWPZQxa3zEjZw33uDRjU5SQCxyQ/NAipSCnxk7xpIasiAN5O56jLgDZgkx+0O2Ue1TDKGRlRw1S3Yb1zTK9LCes9vgv6oBN2/0l9quEjJ71xi3JJQ0hqUDvYQtMQ3RPclvjhDEsv7Eufy52OqS6j3TUkfK0NP8qh+9G7tMWluKOgpjM33d3dCCeB0Bb0XpINpuW4VWCA4/Gt7rpF1rX4W5h+lAt8Q8ljZ5lLWdUk7fbf04GUwhfhw0pr+nMntTEc7xPEUn49nK2eyHoPQULxQUF8zR6sb/4ZtyX4MvqKn44SC0k2oHOCOyrALIsOuR6/AS5pTlp829Nb6yO1y1y112TNkHjDfSc0kKNfCQszE8T4U/2QoLeNdW7rdEjx6y/78Vi6Ib6i/FtB3ltFmlXiii7Tlu6mYDurKbtcP5O/YWNgxv9kvpg7b8dHVZasqtT7eZ7mE2pO3mX7RfVtvcYpHIBsDBXE7LO+ZMC/YaVFiyvV26Rg25x+DRIf1X4oSjl+OYiDbROOV2ayg9WzB3ZXn/geVUKFpQEN9Q0vIexni1nJUJqdcc7z0N+uIUTKhGkXMr652fHKMqjVXc9gaeByNOrOreUQK+sJ9i X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(39860400002)(366004)(346002)(136003)(451199015)(66899015)(36756003)(31686004)(6486002)(5660300002)(8936002)(966005)(66556008)(83380400001)(41300700001)(66946007)(2906002)(478600001)(44832011)(8676002)(66476007)(316002)(26005)(6512007)(53546011)(186003)(38100700002)(2616005)(31696002)(6506007)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8276 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 312363e8-ae48-4fca-2025-08dac266ea78 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MiFSaWZa1QBxrs5B5pjxhqDIL4fZW2mrPgzegfCT9Jh6CKAV6GiBx0VUOmGN6ytMDajzLqL5b0AAsFcVn1PGPScBaKdzLaM0SqUYHKVMdMNkIsjlqiRCKptzuHXaQ9ySeKj7wPW7C4I2K6pk2iFoTpGNwQ2PWSYWhL8trS+f0HYiskffywV11ojO+EUZ/neCuTQlBE5NXUAg7q2VIKosHW2SGEftAySB8yER5+H2r0VBoKLhoqT2ssiJ/Y5O2eb0Q4KTxRegkskS53sZzFGLLjCfCFNXyMdfJFyRG2KKMQMd0ksfCtB1I5n78/RFQ+L3IrSvJuG5yP0PIBdVVQzZJ19Ll0LuvwiluoFsisRpcqvbha5g9qrBWAnaYxKjaWXC5+U3+acHXsoM39iuaScpDWFe0EdmqxoB1Q9c2i2MVrVJovLoVaBjqsrmoRiyXGEJos/cielKPlABYE/yesXarDVznrwLrjLkyy4lYGTzeX+meCVMiqqTue38a7ROQx3uVE5E4F5HZ8J5ocuacH2HeZSlO80AD7xCNPQAwEeRYlmo1m/WeJDAB5Gmvwne/rTb1fnbMVPn9m9RQHyGiZAuj/ZYb5DfSEr9xRojU9Up71Hi2omd6572KKK9I3352g3MlbGjHpB4SU8gyJk0fC0M4btLOZPK/8/N32gW9FosFpCgF7Cyy5nQT8yZdply/IT9MRN9UtlCZFad6t4ZJNJpIz614MQCbg7uwyc5priqc3Qd2TncjWm3dzj7ytfSnGB1bb6TwpLwh8tbRYxU47C9yb3EIl3QN9N6eQ/wTVKQDJaaKbdNhigYAFX1aqWlUKX7 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199015)(40470700004)(36840700001)(46966006)(478600001)(81166007)(31686004)(356005)(66899015)(82310400005)(966005)(6486002)(31696002)(82740400003)(86362001)(41300700001)(336012)(40480700001)(316002)(47076005)(36756003)(2906002)(8936002)(5660300002)(70586007)(36860700001)(70206006)(53546011)(26005)(6506007)(83380400001)(40460700003)(2616005)(186003)(6512007)(44832011)(8676002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 15:27:44.5602 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eaa583d7-860e-4bb1-7868-08dac266f301 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6166 X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,LIKELY_SPAM_BODY,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On 11/8/22 15:58, Tomas Vanek wrote: > On 08/11/2022 16:52, Tomas Vanek wrote: >> Hi Luis, >> >> On 08/11/2022 12:23, Luis Machado wrote: >>> Hi Tomas, >>> >>> On 11/5/22 09:44, Tomas Vanek wrote: >>>> The M-profile security extension registers will be used for stack >>>> selection in FNC_RETURN and return from secure to non-secure state. >>>> >>>> The presence of the registers is optional. >>>> If one or both are missing the security extension profile is accepted. >>>> The code using the registers must check m_profile_control_[n]?s_regnum >>>> for -1. >>>> >>>> Signed-off-by: Tomas Vanek >>>> --- >>>>   gdb/arm-tdep.c | 20 ++++++++++++++++++++ >>>>   gdb/arm-tdep.h |  2 ++ >>>>   2 files changed, 22 insertions(+) >>>> >>>> diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c >>>> index 3105543..564ee43 100644 >>>> --- a/gdb/arm-tdep.c >>>> +++ b/gdb/arm-tdep.c >>>> @@ -9996,6 +9996,8 @@ enum arm_vfp_cprc_base_type >>>>     int m_profile_psp_ns_regnum = -1; >>>>     int m_profile_msp_s_regnum = -1; >>>>     int m_profile_psp_s_regnum = -1; >>>> +  int m_profile_control_s_regnum = -1; >>>> +  int m_profile_control_ns_regnum = -1; >>>>     int tls_regnum = 0; >>>>       /* If we have an object to base this architecture on, try to determine >>>> @@ -10473,6 +10475,22 @@ enum arm_vfp_cprc_base_type >>>>           } >>>>             m_profile_psp_s_regnum = register_count++; >>>>   +          /* Regard the control_s and control_ns registers optional, >>>> +           * accept the security extension feature even without them */ >>>> +          valid_p = tdesc_numbered_register (feature, tdesc_data.get (), >>>> +                         register_count, "control_s"); >>> >>> What tools are advertising control_s and control_ns? We need to document those properly if we're planning on using them >>> as part of decision-making in GDB. >> >> Good question. >> >> OpenOCD exposes them, like other M-profile security extension registers they have the feature name "v8-m.sp". >> There is a pending patch to change the feature name to "org.gnu.gdb.arm.secext" >> 7265: target/armv7m: fix feature name of ARMv8M security extension regs | https://review.openocd.org/c/openocd/+/7265 >> >> PyOCD exposes them, like other M-profile security extension registers they have the feature name "v8-m.sp". > > Oops, PyOCD exposes just control, no control_s and control_ns variants. > Should we coordinate this a bit better between PyOCD and ST-LINK to expose the same set of registers. That would make it easier for gdb to deal with it. >> >> ST-LINK GDB server. Version 5.6.0 (I assume not the latest version) exposes them (and other M-profile security extension registers too) >> in the feature "org.gnu.gdb.arm.vfp"?? Obviously a bug! >> >> I have no access to Keil tools. >> >> Please be aware that control_s and control_ns are optional, the most of security extension support is functional >> even in the case they are not accessible in the connected gdbserver. >> >>> >>> >>>> +          if (!valid_p) >>>> +        warning (_("M-profile secext feature is missing required register control_s.")); >>>> +          else >>>> +        m_profile_control_s_regnum = register_count++; >>>> + >>>> +          valid_p = tdesc_numbered_register (feature, tdesc_data.get (), >>>> +                         register_count, "control_ns"); >>>> +          if (!valid_p) >>>> +        warning (_("M-profile secext feature is missing required register control_ns.")); >>>> +          else >>>> +        m_profile_control_ns_regnum = register_count++; >>>> + >>>>             have_sec_ext = true; >>>>           } >>>>   @@ -10553,6 +10571,8 @@ enum arm_vfp_cprc_base_type >>>>         tdep->m_profile_psp_ns_regnum = m_profile_psp_ns_regnum; >>>>         tdep->m_profile_msp_s_regnum = m_profile_msp_s_regnum; >>>>         tdep->m_profile_psp_s_regnum = m_profile_psp_s_regnum; >>>> +      tdep->m_profile_control_s_regnum = m_profile_control_s_regnum; >>>> +      tdep->m_profile_control_ns_regnum = m_profile_control_ns_regnum; >>>>       } >>>>       arm_register_g_packet_guesses (gdbarch); >>>> diff --git a/gdb/arm-tdep.h b/gdb/arm-tdep.h >>>> index bcd7e08..11670e9 100644 >>>> --- a/gdb/arm-tdep.h >>>> +++ b/gdb/arm-tdep.h >>>> @@ -133,6 +133,8 @@ struct arm_gdbarch_tdep : gdbarch_tdep_base >>>>     int m_profile_psp_ns_regnum = ARM_SP_REGNUM;    /* M-profile PSP_NS register number.  */ >>>>     int m_profile_msp_s_regnum = ARM_SP_REGNUM;    /* M-profile MSP_S register number.  */ >>>>     int m_profile_psp_s_regnum = ARM_SP_REGNUM;    /* M-profile PSP_S register number.  */ >>>> +  int m_profile_control_s_regnum = -1;        /* M-profile CONTROL_S register number.  */ >>>> +  int m_profile_control_ns_regnum = -1;        /* M-profile CONTROL_NS register number.  */ >>>>       int tls_regnum = 0;        /* Number of the tpidruro register.  */ >>> >> >