From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22304 invoked by alias); 12 Dec 2014 14:38:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22293 invoked by uid 89); 12 Dec 2014 14:38:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Dec 2014 14:38:04 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBCEc1aV030911 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 12 Dec 2014 09:38:02 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBCEbxYq011633; Fri, 12 Dec 2014 09:38:00 -0500 Message-ID: <548AFDC7.3020405@redhat.com> Date: Fri, 12 Dec 2014 14:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [PATCH v3 12/14] add linux_infcall_mmap References: <20141101214552.13230.45564.stgit@host1.jankratochvil.net> <20141101214719.13230.96367.stgit@host1.jankratochvil.net> <54623CA7.8060702@redhat.com> <20141123191136.GA31798@host2.jankratochvil.net> In-Reply-To: <20141123191136.GA31798@host2.jankratochvil.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00282.txt.bz2 On 11/23/2014 07:11 PM, Jan Kratochvil wrote: > On Tue, 11 Nov 2014 17:43:19 +0100, Pedro Alves wrote: >> On 11/01/2014 09:47 PM, Jan Kratochvil wrote: >>> +/* See gdbarch.sh 'infcall_mmap'. */ >>> + >>> +static CORE_ADDR >>> +linux_infcall_mmap (CORE_ADDR size, unsigned prot) >>> +{ >>> + struct objfile *objf; >>> + /* Do there still exist any Linux systems without "mmap64"? >>> + "mmap" uses 64-bit off_t on x86_64 and 32-bit off_t on i386 and x32. */ >>> + struct value *mmap_val = find_function_in_inferior ("mmap64", &objf); >>> + struct value *addr_val; >>> + struct gdbarch *gdbarch = get_objfile_arch (objf); >>> + CORE_ADDR retval; >>> + enum >>> + { >>> + ARG_ADDR, ARG_LENGTH, ARG_PROT, ARG_FLAGS, ARG_FD, ARG_OFFSET, ARG_MAX >>> + }; >>> + struct value *arg[ARG_MAX]; >>> + >>> + arg[ARG_ADDR] = value_from_pointer (builtin_type (gdbarch)->builtin_data_ptr, >>> + 0); >>> + /* Assuming sizeof (unsigned long) == sizeof (size_t). */ >>> + arg[ARG_LENGTH] = value_from_ulongest >>> + (builtin_type (gdbarch)->builtin_unsigned_long, size); >>> + gdb_assert ((prot & ~7) == 0); >>> + arg[ARG_PROT] = value_from_longest (builtin_type (gdbarch)->builtin_int, >>> + 0 >>> + | ((prot & 4) != 0 ? PROT_READ : 0) >>> + | ((prot & 2) != 0 ? PROT_WRITE : 0) >>> + | ((prot & 1) != 0 ? PROT_EXEC : 0)); >>> + arg[ARG_FLAGS] = value_from_longest (builtin_type (gdbarch)->builtin_int, >>> + MAP_PRIVATE | MAP_ANONYMOUS); >> >> PROT_READ, PROT_WRITE, PROT_EXEC, MAP_PRIVATE, MAP_ANONYMOUS >> are host values/macros. > > Added to arch-utils.h: > +/* Symbols for gdbarch_infcall_mmap; their Linux PROT_* system > + definitions would be dependent on compilation host. */ > +#define GDB_MMAP_PROT_READ 0x1 /* Page can be read. */ > +#define GDB_MMAP_PROT_WRITE 0x2 /* Page can be written. */ > +#define GDB_MMAP_PROT_EXEC 0x4 /* Page can be executed. */ > > Added to linux-tdep.c: > +/* Symbols for linux_infcall_mmap's ARG_FLAGS; their Linux MAP_* system > + definitions would be dependent on compilation host. */ > +#define GDB_MMAP_MAP_PRIVATE 0x02 /* Changes are private. */ > +#define GDB_MMAP_MAP_ANONYMOUS 0x20 /* Don't use a file. */ > and > - gdb_assert ((prot & ~7) == 0); > + gdb_assert ((prot & ~(GDB_MMAP_PROT_READ | GDB_MMAP_PROT_WRITE > + | GDB_MMAP_PROT_EXEC)) > + == 0); > > Changed gdbarch.sh comment: > -# PROT has rwx bitmask format - bit 2 (value 4) is for readable memory, bit 1 > -# (value 2) is for writable memory and bit 0 (value 1) is for executable memory. > +# PROT has GDB_MMAP_PROT_* bitmask format. > > Change changed the magic numbers to GDB_MMAP_PROT_* accordingly: > // Make the memory always readable. > - prot = 4; > + prot = GDB_MMAP_PROT_READ; > if ((bfd_get_section_flags (abfd, sect) & SEC_READONLY) == 0) > - prot |= 2; > + prot |= GDB_MMAP_PROT_WRITE; > if ((bfd_get_section_flags (abfd, sect) & SEC_CODE) != 0) > - prot |= 1; > + prot |= GDB_MMAP_PROT_EXEC; > [...] > - TYPE_LENGTH (regs_type), 4); > + TYPE_LENGTH (regs_type), > + GDB_MMAP_PROT_READ); > Thanks Jan. This sounds good. Thanks, Pedro Alves