* [PATCH] Restore check-gdb.% target
@ 2014-12-09 21:01 Jason Merrill
2014-12-12 14:53 ` Pedro Alves
0 siblings, 1 reply; 4+ messages in thread
From: Jason Merrill @ 2014-12-09 21:01 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
I found the check-gdb.cp target useful for testing G++, and was sorry to
lose it in the change to improve parallel testing. This patch recreates
that target using the new testing machinery.
Not a big deal if you don't want to make this change, I'll just modify
my testing scripts to do the more verbose make check
TESTS="gdb.cp/*.exp". But I figured other people might find the short
form convenient and/or habitual.
[-- Attachment #2: check-gdb.patch --]
[-- Type: text/x-patch, Size: 565 bytes --]
commit 105041cc6a1d53cae6753409d2d4a145bef3cb51
Author: Jason Merrill <jason@redhat.com>
Date: Tue Dec 9 15:50:03 2014 -0500
* Makefile.in (check-gdb.%): Restore.
diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index 1c923cd..21a1c12 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -188,6 +188,9 @@ DO_RUNTEST = \
@GMAKE_TRUE@endif
@GMAKE_FALSE@expanded_tests_or_none = $(TESTS)
+check-gdb.%:
+ $(MAKE) check TESTS="gdb.$*/*.exp"
+
check-single:
$(DO_RUNTEST) $(RUNTESTFLAGS) $(expanded_tests_or_none)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Restore check-gdb.% target
2014-12-09 21:01 [PATCH] Restore check-gdb.% target Jason Merrill
@ 2014-12-12 14:53 ` Pedro Alves
2014-12-12 16:35 ` Jason Merrill
0 siblings, 1 reply; 4+ messages in thread
From: Pedro Alves @ 2014-12-12 14:53 UTC (permalink / raw)
To: Jason Merrill, gdb-patches
On 12/09/2014 09:01 PM, Jason Merrill wrote:
> I found the check-gdb.cp target useful for testing G++, and was sorry to
> lose it in the change to improve parallel testing. This patch recreates
> that target using the new testing machinery.
>
> Not a big deal if you don't want to make this change, I'll just modify
> my testing scripts to do the more verbose make check
> TESTS="gdb.cp/*.exp". But I figured other people might find the short
> form convenient and/or habitual.
Looks convenient indeed. Fine with me to restore it. Could you add a
short blurb to testsuite/README mentioning this?
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Restore check-gdb.% target
2014-12-12 14:53 ` Pedro Alves
@ 2014-12-12 16:35 ` Jason Merrill
2014-12-15 12:27 ` Pedro Alves
0 siblings, 1 reply; 4+ messages in thread
From: Jason Merrill @ 2014-12-12 16:35 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
On 12/12/2014 09:53 AM, Pedro Alves wrote:
> Looks convenient indeed. Fine with me to restore it. Could you add a
> short blurb to testsuite/README mentioning this?
Like so?
[-- Attachment #2: check-gdb.patch --]
[-- Type: text/x-patch, Size: 1384 bytes --]
commit f8ad961a3858947176a7ed20e3ecf410d6c50da5
Author: Jason Merrill <jason@redhat.com>
Date: Tue Dec 9 15:50:03 2014 -0500
* Makefile.in (check-gdb.%): Restore.
* README: Mention it.
diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index 1c923cd..07d3942 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -188,6 +188,10 @@ DO_RUNTEST = \
@GMAKE_TRUE@endif
@GMAKE_FALSE@expanded_tests_or_none = $(TESTS)
+# Shorthand for running all the tests in a single directory.
+@GMAKE_TRUE@check-gdb.%:
+@GMAKE_TRUE@ $(MAKE) check TESTS="gdb.$*/*.exp"
+
check-single:
$(DO_RUNTEST) $(RUNTESTFLAGS) $(expanded_tests_or_none)
diff --git a/gdb/testsuite/README b/gdb/testsuite/README
index 9a5059a..fa17781 100644
--- a/gdb/testsuite/README
+++ b/gdb/testsuite/README
@@ -160,7 +160,9 @@ list of tests to run.
If using GNU make then the contents are wildcard-expanded using
GNU make's $(wildcard) function. Test paths must be fully specified,
relative to the "testsuite" subdirectory. This allows one to run all
-tests in a subdirectory by passing "gdb.subdir/*.exp".
+tests in a subdirectory by passing "gdb.subdir/*.exp", or more simply
+by using the check-gdb.subdir target in the Makefile.
+
If for some strange reason one wanted to run all tests that begin with
the letter "d" that is also possible: TESTS="*/d*.exp".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Restore check-gdb.% target
2014-12-12 16:35 ` Jason Merrill
@ 2014-12-15 12:27 ` Pedro Alves
0 siblings, 0 replies; 4+ messages in thread
From: Pedro Alves @ 2014-12-15 12:27 UTC (permalink / raw)
To: Jason Merrill, gdb-patches
On 12/12/2014 04:34 PM, Jason Merrill wrote:
> On 12/12/2014 09:53 AM, Pedro Alves wrote:
>> > Looks convenient indeed. Fine with me to restore it. Could you add a
>> > short blurb to testsuite/README mentioning this?
> Like so?
OK, thanks.
--
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-15 12:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-09 21:01 [PATCH] Restore check-gdb.% target Jason Merrill
2014-12-12 14:53 ` Pedro Alves
2014-12-12 16:35 ` Jason Merrill
2014-12-15 12:27 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).