From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6504 invoked by alias); 15 Dec 2014 16:41:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6495 invoked by uid 89); 15 Dec 2014 16:41:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 15 Dec 2014 16:41:22 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 31.D9.25146.D52BE845; Mon, 15 Dec 2014 11:05:17 +0100 (CET) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.84) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 15 Dec 2014 11:41:20 -0500 Message-ID: <548F0F2E.90002@ericsson.com> Date: Mon, 15 Dec 2014 16:41:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Joel Brobecker CC: , Subject: Re: [PATCH 1/3] python extended prompt: Use os.getcwd() instead of os.getcwdu() References: <1416976561-1927-1-git-send-email-simon.marchi@ericsson.com> <20141127090037.GG5042@adacore.com> <54789982.5020604@ericsson.com> <20141129114203.GN5042@adacore.com> <5482173F.3040507@ericsson.com> In-Reply-To: <5482173F.3040507@ericsson.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00398.txt.bz2 On 2014-12-05 03:36 PM, Simon Marchi wrote: > On 2014-11-29 06:42 AM, Joel Brobecker wrote: >>>> I'd like to have other people's opinion on this, as I am not sure. >>>> >>>> I _think_ that the patch is not making things worse for us, >>>> while making things a little better in situations as the above. >>>> So, based on that, I'd be inclined to apply it. >>>> >>>> However, I think the long term fix would be, I believe, to switch >>>> the entire thing to unicode. With Python3, it's automatic, but >>>> with Python2, we might have to add 'u'-s on every piece of string >>>> in the module, and also add some conversions here and there. >>>> That's why I am thinking that the long term fix should be a blocker >>>> for this patch. >>>> >>>> Thoughts? >>> >>> An eventual switch to use unicode everywhere would certainly undo this >>> patch. However, I don't see the point in leaving the broken code as-is, >>> unless there are imminent plans to make that switch happen. >> >> That's exactly my thinking. But not being very familiar with this >> area, and the handling of unicode, I would like to give others >> an opportunity to jump in. Let's wait another week, and see if >> we get additional feedback. If not, we'll push the patch. > > All right, if nothing comes up about this, I'll push it Monday, first thing > in the morning, while eating my cereals. I just pushed this. Thanks.