From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9471 invoked by alias); 17 Dec 2014 10:53:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9462 invoked by uid 89); 17 Dec 2014 10:53:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 17 Dec 2014 10:53:23 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBHArLfb009995 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 17 Dec 2014 05:53:21 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBHArIcu029383; Wed, 17 Dec 2014 05:53:19 -0500 Message-ID: <5491609E.1080204@redhat.com> Date: Wed, 17 Dec 2014 10:53:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] MIPS: Provide FPU info and decode FCSR in `info float' References: <1418798765-23198-1-git-send-email-yao@codesourcery.com> <1418798765-23198-4-git-send-email-yao@codesourcery.com> In-Reply-To: <1418798765-23198-4-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00472.txt.bz2 On 12/17/2014 06:46 AM, Yao Qi wrote: > +static void > +mips_print_float_info (struct gdbarch *gdbarch, struct ui_file *file, > + struct frame_info *frame, const char *args) > +{ > + int fcsr = mips_regnum (gdbarch)->fp_control_status; > + enum mips_fpu_type type = MIPS_FPU_TYPE (gdbarch); > + ULONGEST fcs = 0; > + int i; > + > + if (fcsr == -1 || !deprecated_frame_register_read (frame, fcsr, NULL)) > + type = MIPS_FPU_NONE; "deprecated" method usage alert. It's better to use methods that return values and then print "", "" as appropriate, though in this case you may be able to just use read_frame_register_unsigned instead. > + > + fprintf_filtered (file, "fpu type: %s\n", > + type == MIPS_FPU_DOUBLE ? "double-precision" > + : type == MIPS_FPU_SINGLE ? "single-precision" > + : "none / unused"); > + > + if (type == MIPS_FPU_NONE) > + return; > + Thanks, Pedro Alves