From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] MIPS: Provide FPU info and decode FCSR in `info float'
Date: Thu, 18 Dec 2014 11:16:00 -0000 [thread overview]
Message-ID: <5492B793.6090604@redhat.com> (raw)
In-Reply-To: <87bnn1sr3b.fsf@codesourcery.com>
On 12/18/2014 01:07 AM, Yao Qi wrote:
> Yao Qi <yao@codesourcery.com> writes:
>
>> } elseif [istarget "mips*-*-*"] then {
>> - gdb_test "info float" "f0:.*flt:.*dbl:.*" "info float"
>> + gdb_test_multiple "info float" "info float" {
>> + -re "fpu type: none*" {
>> + pass "info float (without FPU)"
>> + }
>> + -re "fpu type:.*cause.*mask.*flags.*round.*flush.*" {
>> + pass "info float (with FPU)"
>> + }
>> + }
>
> The updated patch adds the "$gdb_prompt $" at the end of those patterns
> and restrict the restrict the patterns.
Thanks, this version looks good to me.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-12-18 11:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 6:46 [PATCH 0/3, V2] " Yao Qi
2014-12-17 6:46 ` [PATCH 2/3] Refactor gdbarch method print_float_info Yao Qi
2014-12-17 13:24 ` Pedro Alves
2014-12-18 1:02 ` Yao Qi
2014-12-18 11:14 ` Pedro Alves
2014-12-17 6:46 ` [PATCH 1/3] Remove h8300_print_float_info Yao Qi
2014-12-17 6:46 ` [PATCH 3/3] MIPS: Provide FPU info and decode FCSR in `info float' Yao Qi
2014-12-17 10:53 ` Pedro Alves
2014-12-17 12:40 ` Yao Qi
2014-12-18 1:07 ` Yao Qi
2014-12-18 11:16 ` Pedro Alves [this message]
2014-12-21 0:14 ` Maciej W. Rozycki
2014-12-18 12:52 ` [PATCH 0/3, V2] " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5492B793.6090604@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).