From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118506-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30847 invoked by alias); 18 Dec 2014 17:40:01 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30833 invoked by uid 89); 18 Dec 2014 17:40:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 18 Dec 2014 17:40:00 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBIHdqVl027715	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Thu, 18 Dec 2014 12:39:53 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBIHdnvf024325;	Thu, 18 Dec 2014 12:39:50 -0500
Message-ID: <54931165.7080103@redhat.com>
Date: Thu, 18 Dec 2014 17:40:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com>,        Michael Eager <eager@eagercon.com>,        Joel Brobecker <brobecker@adacore.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,        Vinod Kathail <vinodk@xilinx.com>,        Vidhumouli Hunsigida <vidhum@xilinx.com>,        Nagaraju Mekala <nmekala@xilinx.com>
Subject: Re: [Patch] Microblaze: Port of Linux gdbserver
References: <25de23b98e054fd291ea232d10f2800c@BN1BFFO11FD018.protection.gbl> <5436B7D0.9060004@eagercon.com> <d0a23ff7601a4dbcab91d5b680bc2e13@BY2FFO11FD017.protection.gbl> <543E7630.5060001@redhat.com> <99de529c620a4bb0a118a9fc39ae6ad0@BY2FFO11FD008.protection.gbl> <548F2240.7020700@redhat.com> <b1a42502cd1843449e5668728141f5ed@BY2FFO11FD059.protection.gbl> <5492BA45.8090205@redhat.com> <8cc311a2f0ac4925b15f90a7b7853db8@BN1AFFO11FD021.protection.gbl>
In-Reply-To: <8cc311a2f0ac4925b15f90a7b7853db8@BN1AFFO11FD021.protection.gbl>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-12/txt/msg00539.txt.bz2

On 12/18/2014 04:53 PM, Ajit Kumar Agarwal wrote:

>> 1. push_dummy_code is not implemented for Micro blaze port  due to this  there are 350+ failures.
> 
>>> Eh, no inferior function call support.  Are you planning on implementing this?
> 
> Currently in the gdb  microblaze-tdep.c, the following code is there for push_dummy_code.
> 
> static CORE_ADDR
> microblaze_push_dummy_code (struct gdbarch *gdbarch, CORE_ADDR sp,
>                             CORE_ADDR funcaddr,
>                             struct value **args, int nargs,
>                             struct type *value_type,
>                             CORE_ADDR *real_pc, CORE_ADDR *bp_addr,
>                             struct regcache *regcache)
> {
>   error (_("push_dummy_code not implemented"));
>   return sp;
> }
> This causes the failures.

Yes, this are the hooks for supporting calling inferior functions
from gdb: "print foo()", etc.

The question was whether you were planning on replacing the
errors (this and microblaze_push_dummy_call's) with a real
implementation.  :-)

Thanks,
Pedro Alves