From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] MIPS: Handle the DSP registers for bare metal
Date: Fri, 19 Dec 2014 11:18:00 -0000 [thread overview]
Message-ID: <5494098B.7080002@redhat.com> (raw)
In-Reply-To: <87r3vwqooq.fsf@codesourcery.com>
On 12/19/2014 03:54 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> Took me a bit to grok this, but this is adding slack for ACXn, right?
>
> Sorry, what do you mean by "slack" here? Is it "gap" or something else?
Yes, "gap".
> The offsets of DSP registers are different on linux and bare metal, so
> this patch gives the correct offset or layout to them.
The proper solution for this issue is to decouple GDB's internal
register numbers from the target's g/G packet layout, which is exactly
what happens when you have a description -- GDB uses the offsets found
in the target description. And you're touching code that is parsing a
description, so the real issue should be in the target description.
>
>> But it seems like nothing in GDB knows about those ACX registers. I
>> guess I'm being dense, but why is this patch needed then? They should still
>> be accessible to the user even without this change, right? Assuming the
>> description is including them.
>
> We want the number of these registers are fixed, and these fixed numbers
> will be used in a follow-up patch about dynamic registers discovery
> (which is about reading available config registers and parsing bits in them)
> MIPS architecture defines 50+ subset of optional CP0 registers, so the
> number of variants is too high to make current static register
> description approach useless.
I think this should be discussed further.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-12-19 11:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 13:26 Yao Qi
2014-12-18 17:28 ` Pedro Alves
2014-12-19 3:55 ` Yao Qi
2014-12-19 11:18 ` Pedro Alves [this message]
2014-12-19 13:22 ` Yao Qi
2014-12-19 15:07 ` Pedro Alves
2014-12-30 1:15 ` Maciej W. Rozycki
2014-12-30 10:12 ` Pedro Alves
2014-12-30 12:11 ` Maciej W. Rozycki
2015-01-05 11:40 ` Pedro Alves
2015-01-07 15:11 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5494098B.7080002@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).