From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-148868-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 39483 invoked by alias); 10 Jul 2018 03:44:02 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 39468 invoked by uid 89); 10 Jul 2018 03:44:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jul 2018 03:44:00 +0000
Received: from [10.0.0.11] (unknown [192.222.164.54])	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id 15CD41E08D;	Mon,  9 Jul 2018 23:43:59 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail;	t=1531194239; bh=fe+K5JtGtVdk6of+kuGXYLlmF/26VJXaukJfQHZYsbo=;	h=Subject:To:References:From:Date:In-Reply-To:From;	b=Uec3ggqWNDv4AQO32u4NN1abqpvuQ/qFwxPdH+rfPB2vZtDaXropaV8bx936wUfZa	 PzQIp/IW5H7Tdm31n9/oEYLhuP0TO/6643vdkS/++oaZqvVHqJIYWfvgBAxF3+NvlZ	 JvUzAmxGlk2SubeL7IBgOB9MaCRQktL5ZSTaqx20=
Subject: Re: [RFA 32/42] Remove EXTERN from buildsym.h
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-33-tom@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <5496087b-d947-7554-ebe3-3f286f5eabf2@simark.ca>
Date: Tue, 10 Jul 2018 03:44:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180523045851.11660-33-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-07/txt/msg00248.txt.bz2

On 2018-05-23 12:58 AM, Tom Tromey wrote:
> Nothing in buildsym.h relies on the "EXTERN" method of
> declaration/definition, so remove the traces.

LGTM.