public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>,
	       Andreas Schwab <schwab@linux-m68k.org>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Sanitize input_interrupt output
Date: Mon, 29 Dec 2014 11:12:00 -0000	[thread overview]
Message-ID: <54A1371C.7000309@redhat.com> (raw)
In-Reply-To: <87lhlslbqg.fsf@redhat.com>

On 12/28/2014 03:00 AM, Sergio Durigan Junior wrote:
> On Saturday, December 27 2014, Andreas Schwab wrote:
> 
>> Sergio Durigan Junior <sergiodj@redhat.com> writes:
>>
>>> +	{
>>> +	  fprintf (stderr, "input_interrupt, count = %d c = %d ", cc, c);
>>> +	  if (isprint (c))
>>> +	    fprintf (stderr, "('%c')\n", c);
>>> +	  else
>>> +	    fprintf (stderr, "('\\x%02x)\n", c & 0xFF);
>>                                        ^
>>
>> Missing second quote character.
> 
> Ops, thanks.  Corrected version below.

OK, but please write "0xff" in lowercase.

Thanks!

Pedro Alves

  reply	other threads:[~2014-12-29 11:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-27  5:24 Sergio Durigan Junior
2014-12-27  8:36 ` Andreas Schwab
2014-12-28  3:01   ` Sergio Durigan Junior
2014-12-29 11:12     ` Pedro Alves [this message]
2014-12-29 19:25       ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54A1371C.7000309@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@linux-m68k.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).