From: Chet Ramey <chet.ramey@case.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: chet.ramey@case.edu, gdb-patches@sourceware.org
Subject: Re: File-name completer marks all files as executable on MS-Windows
Date: Mon, 29 Dec 2014 16:46:00 -0000 [thread overview]
Message-ID: <54A18578.2030204@case.edu> (raw)
In-Reply-To: <83bnmmjuio.fsf@gnu.org>
On 12/29/14 11:22 AM, Eli Zaretskii wrote:
>> Date: Mon, 29 Dec 2014 10:38:45 -0500
>> From: Chet Ramey <chet.ramey@case.edu>
>> CC: chet.ramey@case.edu, gdb-patches@sourceware.org
>>
>> On 12/27/14 2:13 PM, Eli Zaretskii wrote:
>>> I discovered that completing on file names in GDB on MS-Windows marks
>>> every file as executable. This is because Readline uses 'access' and
>>> X_OK to determine that, which doesn't work on Windows.
>>
>> Ugh, really? Thanks for the patch.
>
> Thanks for reviewing it.
>
> Joel, Pedro, others: can I now commit this to the GDB repository?
I am not certain of the exact vintage of the copy of readline in the GDB
repository, but you should probably audit it and see whether or not this
patch should use `fn' instead of `filename'.
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/
next prev parent reply other threads:[~2014-12-29 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 19:13 Eli Zaretskii
2014-12-27 22:00 ` Andrew Pinski
2014-12-28 3:38 ` Eli Zaretskii
2014-12-29 15:38 ` Chet Ramey
2014-12-29 16:22 ` Eli Zaretskii
2014-12-29 16:46 ` Chet Ramey [this message]
2014-12-29 17:34 ` Eli Zaretskii
2014-12-29 19:00 ` Pedro Alves
2014-12-30 19:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A18578.2030204@case.edu \
--to=chet.ramey@case.edu \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).