From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11166 invoked by alias); 29 Dec 2014 16:46:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11153 invoked by uid 89); 29 Dec 2014 16:46:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mpv1.tis.cwru.edu Received: from mpv1.tis.cwru.edu (HELO mpv1.tis.cwru.edu) (129.22.105.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Mon, 29 Dec 2014 16:46:54 +0000 Received: from mpv6.tis.CWRU.Edu (EHLO mpv6.cwru.edu) ([129.22.104.221]) by mpv1.tis.cwru.edu (MOS 4.3.5-GA FastPath queued) with ESMTP id BPL07895; Mon, 29 Dec 2014 11:46:49 -0500 (EST) Received: from caleb.INS.CWRU.Edu (EHLO caleb.INS.CWRU.Edu) ([129.22.8.211]) by mpv6.cwru.edu (MOS 4.3.5-GA FastPath queued) with ESMTP id AVH97283 (AUTH cpr); Mon, 29 Dec 2014 11:46:44 -0500 (EST) Message-ID: <54A18578.2030204@case.edu> Date: Mon, 29 Dec 2014 16:46:00 -0000 From: Chet Ramey Reply-To: chet.ramey@case.edu User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Eli Zaretskii CC: chet.ramey@case.edu, gdb-patches@sourceware.org Subject: Re: File-name completer marks all files as executable on MS-Windows References: <83egrklxde.fsf@gnu.org> <54A17585.5010900@case.edu> <83bnmmjuio.fsf@gnu.org> In-Reply-To: <83bnmmjuio.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Junkmail-Whitelist: YES (by domain whitelist at mpv1.tis.cwru.edu) X-SW-Source: 2014-12/txt/msg00666.txt.bz2 On 12/29/14 11:22 AM, Eli Zaretskii wrote: >> Date: Mon, 29 Dec 2014 10:38:45 -0500 >> From: Chet Ramey >> CC: chet.ramey@case.edu, gdb-patches@sourceware.org >> >> On 12/27/14 2:13 PM, Eli Zaretskii wrote: >>> I discovered that completing on file names in GDB on MS-Windows marks >>> every file as executable. This is because Readline uses 'access' and >>> X_OK to determine that, which doesn't work on Windows. >> >> Ugh, really? Thanks for the patch. > > Thanks for reviewing it. > > Joel, Pedro, others: can I now commit this to the GDB repository? I am not certain of the exact vintage of the copy of readline in the GDB repository, but you should probably audit it and see whether or not this patch should use `fn' instead of `filename'. -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/