From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21798 invoked by alias); 29 Dec 2014 19:00:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21770 invoked by uid 89); 29 Dec 2014 19:00:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 29 Dec 2014 19:00:11 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBTJ006F010655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 29 Dec 2014 14:00:01 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBTIxn44021768; Mon, 29 Dec 2014 13:59:54 -0500 Message-ID: <54A1A4A4.2070600@redhat.com> Date: Mon, 29 Dec 2014 19:00:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Eli Zaretskii , chet.ramey@case.edu CC: gdb-patches@sourceware.org Subject: Re: File-name completer marks all files as executable on MS-Windows References: <83egrklxde.fsf@gnu.org> <54A17585.5010900@case.edu> <83bnmmjuio.fsf@gnu.org> In-Reply-To: <83bnmmjuio.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00669.txt.bz2 On 12/29/2014 04:22 PM, Eli Zaretskii wrote: >> Date: Mon, 29 Dec 2014 10:38:45 -0500 >> From: Chet Ramey >> CC: chet.ramey@case.edu, gdb-patches@sourceware.org >> >> On 12/27/14 2:13 PM, Eli Zaretskii wrote: >>> I discovered that completing on file names in GDB on MS-Windows marks >>> every file as executable. This is because Readline uses 'access' and >>> X_OK to determine that, which doesn't work on Windows. >> >> Ugh, really? Thanks for the patch. > > Thanks for reviewing it. > > Joel, Pedro, others: can I now commit this to the GDB repository? > Branch too? Fine with me. Thanks, Pedro Alves