public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCHSET] [1/4] Fix various issue in TUI
Date: Mon, 05 Jan 2015 19:20:00 -0000	[thread overview]
Message-ID: <54AAE3E2.4010705@redhat.com> (raw)
In-Reply-To: <83zja3buah.fsf@gnu.org>

On 12/31/2014 05:31 PM, Eli Zaretskii wrote:
> This patch leaves more place on the status line for the process/thread
> ID info, so that the probability of chopping it is significantly lower.
> 
> OK to commit?
> 
> 2014-12-31  Eli Zaretskii  <eliz@gnu.org>
> 
> 	* tui/tui-data.h (LINE_PREFIX): Make shorter.
> 	(MAX_PID_WIDTH): Leave 5 more characters.

OK.

(Please recall to give the commit a more specific subject line
though, rather than having all 4 patches with the same subject.)

>  /* Strings to display in the TUI status line.  */
>  #define PROC_PREFIX             "In: "
> -#define LINE_PREFIX             "Line: "
> +#define LINE_PREFIX             "L"

I have to a admit this one looked a little odd to me,
but I guess it's a matter of habit.

Thanks,
Pedro Alves

  reply	other threads:[~2015-01-05 19:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-31 17:31 Eli Zaretskii
2015-01-05 19:20 ` Pedro Alves [this message]
2015-01-06 15:56   ` Eli Zaretskii
2015-01-16 11:26   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AAE3E2.4010705@redhat.com \
    --to=palves@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).