* [PATCHSET] [1/4] Fix various issue in TUI
@ 2014-12-31 17:31 Eli Zaretskii
2015-01-05 19:20 ` Pedro Alves
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2014-12-31 17:31 UTC (permalink / raw)
To: gdb-patches
This patch leaves more place on the status line for the process/thread
ID info, so that the probability of chopping it is significantly lower.
OK to commit?
2014-12-31 Eli Zaretskii <eliz@gnu.org>
* tui/tui-data.h (LINE_PREFIX): Make shorter.
(MAX_PID_WIDTH): Leave 5 more characters.
--- gdb/tui/tui-data.h~0 2014-06-11 18:34:41 +0300
+++ gdb/tui/tui-data.h 2014-12-31 09:55:03 +0200
@@ -75,7 +75,7 @@
/* Strings to display in the TUI status line. */
#define PROC_PREFIX "In: "
-#define LINE_PREFIX "Line: "
+#define LINE_PREFIX "L"
#define PC_PREFIX "PC: "
#define SINGLE_KEY "(SingleKey)"
@@ -85,7 +85,7 @@
numbers. */
#define MIN_PROC_WIDTH 12
#define MAX_TARGET_WIDTH 10
-#define MAX_PID_WIDTH 14
+#define MAX_PID_WIDTH 19
#define TUI_FLOAT_REGS_NAME "$FREGS"
#define TUI_FLOAT_REGS_NAME_LOWER "$fregs"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHSET] [1/4] Fix various issue in TUI
2014-12-31 17:31 [PATCHSET] [1/4] Fix various issue in TUI Eli Zaretskii
@ 2015-01-05 19:20 ` Pedro Alves
2015-01-06 15:56 ` Eli Zaretskii
2015-01-16 11:26 ` Eli Zaretskii
0 siblings, 2 replies; 4+ messages in thread
From: Pedro Alves @ 2015-01-05 19:20 UTC (permalink / raw)
To: Eli Zaretskii, gdb-patches
On 12/31/2014 05:31 PM, Eli Zaretskii wrote:
> This patch leaves more place on the status line for the process/thread
> ID info, so that the probability of chopping it is significantly lower.
>
> OK to commit?
>
> 2014-12-31 Eli Zaretskii <eliz@gnu.org>
>
> * tui/tui-data.h (LINE_PREFIX): Make shorter.
> (MAX_PID_WIDTH): Leave 5 more characters.
OK.
(Please recall to give the commit a more specific subject line
though, rather than having all 4 patches with the same subject.)
> /* Strings to display in the TUI status line. */
> #define PROC_PREFIX "In: "
> -#define LINE_PREFIX "Line: "
> +#define LINE_PREFIX "L"
I have to a admit this one looked a little odd to me,
but I guess it's a matter of habit.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHSET] [1/4] Fix various issue in TUI
2015-01-05 19:20 ` Pedro Alves
@ 2015-01-06 15:56 ` Eli Zaretskii
2015-01-16 11:26 ` Eli Zaretskii
1 sibling, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2015-01-06 15:56 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
> Date: Mon, 05 Jan 2015 19:20:02 +0000
> From: Pedro Alves <palves@redhat.com>
>
> > /* Strings to display in the TUI status line. */
> > #define PROC_PREFIX "In: "
> > -#define LINE_PREFIX "Line: "
> > +#define LINE_PREFIX "L"
>
> I have to a admit this one looked a little odd to me,
> but I guess it's a matter of habit.
Well, Emacs shows "Lnnn", so the habit is already here ;-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHSET] [1/4] Fix various issue in TUI
2015-01-05 19:20 ` Pedro Alves
2015-01-06 15:56 ` Eli Zaretskii
@ 2015-01-16 11:26 ` Eli Zaretskii
1 sibling, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2015-01-16 11:26 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
> Date: Mon, 05 Jan 2015 19:20:02 +0000
> From: Pedro Alves <palves@redhat.com>
>
> On 12/31/2014 05:31 PM, Eli Zaretskii wrote:
> > This patch leaves more place on the status line for the process/thread
> > ID info, so that the probability of chopping it is significantly lower.
> >
> > OK to commit?
> >
> > 2014-12-31 Eli Zaretskii <eliz@gnu.org>
> >
> > * tui/tui-data.h (LINE_PREFIX): Make shorter.
> > (MAX_PID_WIDTH): Leave 5 more characters.
>
> OK.
>
> (Please recall to give the commit a more specific subject line
> though, rather than having all 4 patches with the same subject.)
>
> > /* Strings to display in the TUI status line. */
> > #define PROC_PREFIX "In: "
> > -#define LINE_PREFIX "Line: "
> > +#define LINE_PREFIX "L"
>
> I have to a admit this one looked a little odd to me,
> but I guess it's a matter of habit.
Thanks, pushed.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-16 11:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-31 17:31 [PATCHSET] [1/4] Fix various issue in TUI Eli Zaretskii
2015-01-05 19:20 ` Pedro Alves
2015-01-06 15:56 ` Eli Zaretskii
2015-01-16 11:26 ` Eli Zaretskii
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).