* [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin
@ 2014-09-15 21:25 James Clarke
2014-09-15 21:36 ` Sergio Durigan Junior
2014-09-16 8:41 ` Tristan Gingold
0 siblings, 2 replies; 8+ messages in thread
From: James Clarke @ 2014-09-15 21:25 UTC (permalink / raw)
To: gdb-patches; +Cc: James Clarke
The `machine/setjmp.h' header is no longer present on OS X 10.10, and is
non-standard. Instead, `darwin-nat.c' should be using the standard
`setjmp.h' header.
gdb/ChangeLog:
2014-09-15 James Clarke <jrtc27@jrtc27.com>
PR gdb/17046
* darwin-nat.c: Import standard setjmp.h rather than the non-standard
machine/setjmp.h header that no longer exists as of OS X 10.10.
---
gdb/darwin-nat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
index af4ec01..e550785 100644
--- a/gdb/darwin-nat.c
+++ b/gdb/darwin-nat.c
@@ -42,7 +42,7 @@
#include <sys/ptrace.h>
#include <sys/signal.h>
-#include <machine/setjmp.h>
+#include <setjmp.h>
#include <sys/types.h>
#include <unistd.h>
#include <signal.h>
--
2.1.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin
2014-09-15 21:25 [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin James Clarke
@ 2014-09-15 21:36 ` Sergio Durigan Junior
2014-09-15 23:45 ` James Clarke
2014-09-16 8:41 ` Tristan Gingold
1 sibling, 1 reply; 8+ messages in thread
From: Sergio Durigan Junior @ 2014-09-15 21:36 UTC (permalink / raw)
To: James Clarke; +Cc: gdb-patches
On Monday, September 15 2014, James Clarke wrote:
> The `machine/setjmp.h' header is no longer present on OS X 10.10, and is
> non-standard. Instead, `darwin-nat.c' should be using the standard
> `setjmp.h' header.
Thanks.
I am not a Mac user, and I know nothing about the details of the system,
but I did a little investigation and I think this is the right fix
indeed.
FWIW, I found
<https://lists.macosforge.org/pipermail/macports-tickets/2014-June/163911.html>
which is a related discussion.
This is not an approval, BTW.
> gdb/ChangeLog:
>
> 2014-09-15 James Clarke <jrtc27@jrtc27.com>
>
> PR gdb/17046
> * darwin-nat.c: Import standard setjmp.h rather than the non-standard
> machine/setjmp.h header that no longer exists as of OS X 10.10.
> ---
> gdb/darwin-nat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
> index af4ec01..e550785 100644
> --- a/gdb/darwin-nat.c
> +++ b/gdb/darwin-nat.c
> @@ -42,7 +42,7 @@
>
> #include <sys/ptrace.h>
> #include <sys/signal.h>
> -#include <machine/setjmp.h>
> +#include <setjmp.h>
> #include <sys/types.h>
> #include <unistd.h>
> #include <signal.h>
> --
> 2.1.0
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin
2014-09-15 21:36 ` Sergio Durigan Junior
@ 2014-09-15 23:45 ` James Clarke
0 siblings, 0 replies; 8+ messages in thread
From: James Clarke @ 2014-09-15 23:45 UTC (permalink / raw)
Cc: gdb-patches
That’s where I got the fix from. Not quite sure why this include location
was chosen in the first place; `setjmp.h' was a standard header in pure
ANSI C. The only reason I can think of is that older versions had
`setjmp.h’ which simply includes `machine/setjmp.h’, which had the actual
definitions.
James Clarke
> On 15 Sep 2014, at 22:35, Sergio Durigan Junior <sergiodj@redhat.com> wrote:
>
> On Monday, September 15 2014, James Clarke wrote:
>
>> The `machine/setjmp.h' header is no longer present on OS X 10.10, and is
>> non-standard. Instead, `darwin-nat.c' should be using the standard
>> `setjmp.h' header.
>
> Thanks.
>
> I am not a Mac user, and I know nothing about the details of the system,
> but I did a little investigation and I think this is the right fix
> indeed.
>
> FWIW, I found
> <https://lists.macosforge.org/pipermail/macports-tickets/2014-June/163911.html>
> which is a related discussion.
>
> This is not an approval, BTW.
>
> --
> Sergio
> GPG key ID: 0x65FC5E36
> Please send encrypted e-mail if possible
> http://sergiodj.net/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin
2014-09-15 21:25 [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin James Clarke
2014-09-15 21:36 ` Sergio Durigan Junior
@ 2014-09-16 8:41 ` Tristan Gingold
2015-01-06 22:42 ` Simon Marchi
1 sibling, 1 reply; 8+ messages in thread
From: Tristan Gingold @ 2014-09-16 8:41 UTC (permalink / raw)
To: James Clarke; +Cc: gdb-patches
On 15 Sep 2014, at 23:24, James Clarke <jrtc27@jrtc27.com> wrote:
> The `machine/setjmp.h' header is no longer present on OS X 10.10, and is
> non-standard. Instead, `darwin-nat.c' should be using the standard
> `setjmp.h' header.
>
> gdb/ChangeLog:
>
> 2014-09-15 James Clarke <jrtc27@jrtc27.com>
>
> PR gdb/17046
> * darwin-nat.c: Import standard setjmp.h rather than the non-standard
> machine/setjmp.h header that no longer exists as of OS X 10.10.
Yes, this is indeed obvious.
Please commit.
Tristan.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin
2014-09-16 8:41 ` Tristan Gingold
@ 2015-01-06 22:42 ` Simon Marchi
2015-01-12 13:41 ` Simon Marchi
0 siblings, 1 reply; 8+ messages in thread
From: Simon Marchi @ 2015-01-06 22:42 UTC (permalink / raw)
To: Tristan Gingold, James Clarke; +Cc: gdb-patches
On 14-09-16 04:40 AM, Tristan Gingold wrote:
>
> On 15 Sep 2014, at 23:24, James Clarke <jrtc27@jrtc27.com> wrote:
>
>> The `machine/setjmp.h' header is no longer present on OS X 10.10, and is
>> non-standard. Instead, `darwin-nat.c' should be using the standard
>> `setjmp.h' header.
>>
>> gdb/ChangeLog:
>>
>> 2014-09-15 James Clarke <jrtc27@jrtc27.com>
>>
>> PR gdb/17046
>> * darwin-nat.c: Import standard setjmp.h rather than the non-standard
>> machine/setjmp.h header that no longer exists as of OS X 10.10.
>
> Yes, this is indeed obvious.
>
> Please commit.
>
> Tristan.
Hi Tristan and James,
My mac-user friend mentioned that he needed this fix to build gdb, and wondered
why it had not been merged (fell between cracks I suppose).
Thanks,
Simon
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin
2015-01-06 22:42 ` Simon Marchi
@ 2015-01-12 13:41 ` Simon Marchi
2015-01-12 17:21 ` Joel Brobecker
0 siblings, 1 reply; 8+ messages in thread
From: Simon Marchi @ 2015-01-12 13:41 UTC (permalink / raw)
To: gdb-patches
On 15-01-06 05:42 PM, Simon Marchi wrote:
> On 14-09-16 04:40 AM, Tristan Gingold wrote:
>>
>> On 15 Sep 2014, at 23:24, James Clarke <jrtc27@jrtc27.com> wrote:
>>
>>> The `machine/setjmp.h' header is no longer present on OS X 10.10, and is
>>> non-standard. Instead, `darwin-nat.c' should be using the standard
>>> `setjmp.h' header.
>>>
>>> gdb/ChangeLog:
>>>
>>> 2014-09-15 James Clarke <jrtc27@jrtc27.com>
>>>
>>> PR gdb/17046
>>> * darwin-nat.c: Import standard setjmp.h rather than the non-standard
>>> machine/setjmp.h header that no longer exists as of OS X 10.10.
>>
>> Yes, this is indeed obvious.
>>
>> Please commit.
>>
>> Tristan.
>
> Hi Tristan and James,
>
> My mac-user friend mentioned that he needed this fix to build gdb, and wondered
> why it had not been merged (fell between cracks I suppose).
>
> Thanks,
>
> Simon
I'll push this as obvious on Friday if it hasn't been already.
Simon
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin
2015-01-12 13:41 ` Simon Marchi
@ 2015-01-12 17:21 ` Joel Brobecker
2015-01-12 17:49 ` Simon Marchi
0 siblings, 1 reply; 8+ messages in thread
From: Joel Brobecker @ 2015-01-12 17:21 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
> >>> 2014-09-15 James Clarke <jrtc27@jrtc27.com>
> >>>
> >>> PR gdb/17046
> >>> * darwin-nat.c: Import standard setjmp.h rather than the non-standard
> >>> machine/setjmp.h header that no longer exists as of OS X 10.10.
[...]
> I'll push this as obvious on Friday if it hasn't been already.
Given that branching is potentially tomorrow, and that this causes
a build failure for which the only workaround is to edit the code,
I just pushed it now. That way, we won't have to push it on the branch
after we've created it.
https://www.sourceware.org/ml/gdb-cvs/2015-01/msg00090.html
--
Joel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin
2015-01-12 17:21 ` Joel Brobecker
@ 2015-01-12 17:49 ` Simon Marchi
0 siblings, 0 replies; 8+ messages in thread
From: Simon Marchi @ 2015-01-12 17:49 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches
On 15-01-12 12:21 PM, Joel Brobecker wrote:
>>>>> 2014-09-15 James Clarke <jrtc27@jrtc27.com>
>>>>>
>>>>> PR gdb/17046
>>>>> * darwin-nat.c: Import standard setjmp.h rather than the non-standard
>>>>> machine/setjmp.h header that no longer exists as of OS X 10.10.
> [...]
>> I'll push this as obvious on Friday if it hasn't been already.
>
> Given that branching is potentially tomorrow, and that this causes
> a build failure for which the only workaround is to edit the code,
> I just pushed it now. That way, we won't have to push it on the branch
> after we've created it.
>
> https://www.sourceware.org/ml/gdb-cvs/2015-01/msg00090.html
Thanks a lot!
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-01-12 17:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-15 21:25 [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin James Clarke
2014-09-15 21:36 ` Sergio Durigan Junior
2014-09-15 23:45 ` James Clarke
2014-09-16 8:41 ` Tristan Gingold
2015-01-06 22:42 ` Simon Marchi
2015-01-12 13:41 ` Simon Marchi
2015-01-12 17:21 ` Joel Brobecker
2015-01-12 17:49 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).