From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118770-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29374 invoked by alias); 7 Jan 2015 13:48:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 29363 invoked by uid 89); 7 Jan 2015 13:48:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 07 Jan 2015 13:48:42 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t07Dmc1l027165	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Wed, 7 Jan 2015 08:48:39 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t07DmTIo022450;	Wed, 7 Jan 2015 08:48:33 -0500
Message-ID: <54AD392C.1030209@redhat.com>
Date: Wed, 07 Jan 2015 13:48:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Eli Zaretskii <eliz@gnu.org>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCHSET] [2/4] Fix various issue in TUI
References: <83y4pnbtnc.fsf@gnu.org> <54AAE1D9.9000409@redhat.com> <834ms39a40.fsf@gnu.org>
In-Reply-To: <834ms39a40.fsf@gnu.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-01/txt/msg00104.txt.bz2

On 01/06/2015 03:55 PM, Eli Zaretskii wrote:

> 2015-01-06  Eli Zaretskii  <eliz@gnu.org>
> 
> 	* tui/tui-win.c (tui_set_var_cmd): New function.
> 	(_initialize_tui_win) <border-kind, border-mode>:
> 	<active-border-mode>: Use tui_set_var_cmd as the "set" function.
> 
> --- gdb/tui/tui-win.c~2	2015-01-04 08:07:30 +0200
> +++ gdb/tui/tui-win.c	2015-01-06 08:03:05 +0200
> @@ -346,6 +346,12 @@ tui_get_cmd_list (void)
>    return &tuilist;
>  }
>  
> +void tui_set_var_cmd (char *null_args, int from_tty, struct cmd_list_element *c)

Line break after "void".  Misses an intro comment, maybe something
like:

/* The set_func hook of "set tui ..." settings that affect
   the TUI display.  */

> +{
> +  if (tui_update_variables ())
> +    tui_rehighlight_all ();

The tui_rehighlight_all function is missing in this patch.
Did you indend for this to be tui_refresh_all_win?

Is this OK to call when the tui is not enabled?

Thanks,
Pedro Alves