From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 6/8] linux-nat.c: better starvation avoidance, handle non-stop mode too
Date: Wed, 07 Jan 2015 14:36:00 -0000 [thread overview]
Message-ID: <54AD444C.7050103@redhat.com> (raw)
In-Reply-To: <87wq4yu1i0.fsf@codesourcery.com>
On 01/07/2015 02:08 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> That is, the LWP had previously stopped for a breakpoint, and we
>> left that event pending. But if the breakpoint is now gone,
>> GDB core isn't interested in it anymore, so we just discard
>> that event.
>
> The breakpoint is gone because it is removed by user, for example,
> it that correct?
Yeah, removed for any reason, really. Another example would be because it
was a step-resume breakpoint for another thread and that other thread
no longer needs it, so GDB meanwhile removed it.
>
>> Here's the updated patch.
>
> It looks good to me.
Thank you for the review.
Pedro Alves
next prev parent reply other threads:[~2015-01-07 14:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-26 20:31 [PATCH 0/8] Linux: starvation avoidance in non-stop mode Pedro Alves
2014-12-26 20:31 ` [PATCH 3/8] cleanup and speed up (software_)breakpoint_inserted_here_p Pedro Alves
2014-12-26 20:31 ` [PATCH 2/8] watch_thread_num.exp and targets with fairer event reporting Pedro Alves
2014-12-26 20:31 ` [PATCH 1/8] gdb.threads/{siginfo-thread.c,watchthreads-reorder.c,ia64-sigill.c} races with GDB Pedro Alves
2015-01-06 6:20 ` Yao Qi
2014-12-26 20:32 ` [PATCH 6/8] linux-nat.c: better starvation avoidance, handle non-stop mode too Pedro Alves
2015-01-07 7:06 ` Yao Qi
2015-01-07 13:22 ` Pedro Alves
2015-01-07 14:08 ` Yao Qi
2015-01-07 14:36 ` Pedro Alves [this message]
2014-12-26 20:32 ` [PATCH 8/8] add non-stop test that stresses thread starvation issues Pedro Alves
2015-04-02 14:53 ` Yao Qi
2015-04-06 11:26 ` Pedro Alves
2015-04-07 10:10 ` Yao Qi
2015-04-07 10:22 ` Pedro Alves
2015-04-07 10:31 ` Yao Qi
2014-12-26 20:32 ` [PATCH 5/8] linux-nat.c: always mark execing LWP as resumed Pedro Alves
2014-12-26 20:32 ` [PATCH 4/8] linux-nat.c: clean up pending status checking and resuming LWPs Pedro Alves
2015-01-06 8:12 ` Yao Qi
2015-01-07 13:22 ` Pedro Alves
2015-01-07 14:10 ` Yao Qi
2014-12-26 20:32 ` [PATCH 7/8] [gdbserver] linux-low.c: better starvation avoidance, handle non-stop mode too Pedro Alves
2015-01-09 15:07 ` [PATCH 0/8] Linux: starvation avoidance in non-stop mode Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AD444C.7050103@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).