From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26960 invoked by alias); 7 Jan 2015 15:18:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26817 invoked by uid 89); 7 Jan 2015 15:18:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 07 Jan 2015 15:18:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t07FI6mh031856 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Jan 2015 10:18:07 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t07FHuIp002692; Wed, 7 Jan 2015 10:18:01 -0500 Message-ID: <54AD4E22.1010106@redhat.com> Date: Wed, 07 Jan 2015 15:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Doug Evans , Eli Zaretskii CC: gdb-patches Subject: Re: [PATCH] Speed up "gdb -tui" output References: <83zj9v7urq.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00116.txt.bz2 On 01/06/2015 06:37 PM, Doug Evans wrote: > Having written all that, asking the caller to know to do > wrefresh at the needed times could be onerous. > One thing that occurs to me is that gdb does do things like: > > Reading symbols from foo ... (work work work) done. > And if I do that on my standard monster benchmark (fortunately > I keep a ready-to-use copy lying around for experiments like this :-)) > I see a long pause before "done." is printed. > > And lo and behold, if I apply your patch I see this: > > bash$ gdb -tui > (gdb) file foo > > At this point I've hit return but I don't see anything printed. > > pause pause pause > > and then finally I see all the output: > > Reading symbols from foo...done. > mumble ... > (gdb) Since stdout is line buffered by default (on Unix), if this is working when the TUI is disabled, then it must be because there's explicit gdb_flush(gdb_stdout) after "Reading symbols from foo..." is printed, right? Isn't the issue then that the TUI's implementation of gdb_flush (tui/tui-file.c) should be doing whatever it needs to flush the output? Should it be calling wrefresh if the file is gdb_stdout? If we do that, and change tui_puts like: - /* We could defer the following. */ - wrefresh (w); - fflush (stdout); + if (c == '\n') + gdb_flush (gdb_stdout); would it work? Thanks, Pedro Alves