From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1969 invoked by alias); 8 Jan 2015 10:42:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1955 invoked by uid 89); 8 Jan 2015 10:42:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 08 Jan 2015 10:42:05 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t08Ag2JG015532 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 8 Jan 2015 05:42:02 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t08AfwL1030474; Thu, 8 Jan 2015 05:41:58 -0500 Message-ID: <54AE5EF5.8020804@redhat.com> Date: Thu, 08 Jan 2015 10:42:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Clear upper bits during sign extension References: <1419815569-21854-1-git-send-email-yao@codesourcery.com> <54A13184.1070902@redhat.com> <874msdwl39.fsf@codesourcery.com> <54A29886.8030603@redhat.com> <87vbktuu5p.fsf@codesourcery.com> <87bnm9u8wx.fsf@codesourcery.com> In-Reply-To: <87bnm9u8wx.fsf@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00166.txt.bz2 On 01/08/2015 05:40 AM, Yao Qi wrote: > Yao Qi writes: > >>> + byte_order = gdbarch_byte_order (get_type_arch (type)); >> >> How about getting gdbarch via get_frame_arch (frame)? How about >> removing gdb_sign_extend as it is no longer used? >> >> I'll post a full version on top of yours. > > Here is the patch, what do you think? Looks good to me. Thanks. -- Pedro Alves