From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10607 invoked by alias); 8 Jan 2015 11:39:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10594 invoked by uid 89); 8 Jan 2015 11:39:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 08 Jan 2015 11:39:14 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t08BdBOp030005 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 8 Jan 2015 06:39:11 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t08Bd5MW021316; Thu, 8 Jan 2015 06:39:09 -0500 Message-ID: <54AE6C57.9010203@redhat.com> Date: Thu, 08 Jan 2015 11:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Don't flush the prompt when resizing the terminal within TUI References: <1420689885-31156-1-git-send-email-patrick@parcs.ath.cx> <1420689885-31156-3-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1420689885-31156-3-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00170.txt.bz2 On 01/08/2015 04:04 AM, Patrick Palka wrote: > This patch removes the ancient code that is responsible for forcing the > prompt to get flushed and executed when tui_getc() detects that the > terminal has been resized. This behavior is unintuitive and seemingly > unnecessary. I tried figuring out why tui_getc() behaves this way, but > git-blame does not reveal anything informative about this code. It > probably has something to do with avoiding to print KEY_RESIZE keys, but > the previous patch prevents that from happening anymore. I don't know why it was found necessary either. I agree it's not intuitive. Looks good to me. Thanks, Pedro Alves