From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12191 invoked by alias); 8 Jan 2015 11:40:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12180 invoked by uid 89); 8 Jan 2015 11:40:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 08 Jan 2015 11:40:09 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t08Be60i021684 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 8 Jan 2015 06:40:06 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t08Bdx7B018626; Thu, 8 Jan 2015 06:40:04 -0500 Message-ID: <54AE6C8F.6060109@redhat.com> Date: Thu, 08 Jan 2015 11:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Remove superfluous function key_is_command_char() References: <1420689885-31156-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1420689885-31156-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00171.txt.bz2 On 01/08/2015 04:04 AM, Patrick Palka wrote: > The function key_is_command_char() is simply a predicate that determines > whether the function tui_dispatch_ctrl_char() will do anything useful. > Since tui_dispatch_ctrl_char() performs the same checks as > key_is_command_char() it is unnecessary to keep key_is_command_char() > around. This patch removes this useless function and instead > unconditionally calls tui_dispatch_ctrl_char() inside its only caller, > tui_getc(). > > gdb/ChangeLog: > > * tui/tui-io.c (tui_getc): Don't call key_is_command_char. > (key_is_command_char): Delete. OK. Thanks, Pedro Alves