From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28960 invoked by alias); 8 Jan 2015 12:02:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28948 invoked by uid 89); 8 Jan 2015 12:02:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 08 Jan 2015 12:02:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t08C2YW2010932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 8 Jan 2015 07:02:34 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t08C2S4H032285; Thu, 8 Jan 2015 07:02:29 -0500 Message-ID: <54AE71D2.6020301@redhat.com> Date: Thu, 08 Jan 2015 12:02:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org, Jan Kratochvil Subject: Re: [PATCH] Don't munge yacc's #line directives References: <1420678878-14065-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1420678878-14065-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00172.txt.bz2 On 01/08/2015 01:01 AM, Patrick Palka wrote: > The #line directives within GDB's autogenerated yacc files (e.g. > c-exp.c) are being munged by a dubious sed expression that is causing > these directives to refer to nonexistent source files. As a result it > is currently not possible to debug these source files at source level. > > The culprit sed expression was added by commit 954d8cae for non-obvious > reasons. That predates when we started putting more complete descriptions in the commit log. Did you look for the mailing list patch submission? That should have included a description. If not, then maybe Jan recalls. The expression refers to basename and slashes, it makes me wonder whether this was build-in-srcdir vs build-out-of-srcdir related. > My guess is that the expression was added to work around a bug > in ylwrap which has since been fixed upstream: if I revert the November > 2014 update to ylwrap, commit be3046511, then the culprit sed line no OOC, got url for that git repo? Thanks, Pedro Alves > longer causes the above mentioned issue. > > So this patch removes the culprit sed script since it does not seem > needed anymore; the emitted #line directives look and work fine without > it. > > gdb/ChangeLog: > > 2015-01-07 Patrick Palka > > * Makefile.in (.y.c): Don't munge yacc's #line > directives. > --- > gdb/Makefile.in | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index 31c8a4c..97d0045 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -1856,7 +1856,6 @@ po/$(PACKAGE).pot: force > -e 's/\([ \t;,(]\)free\([ \t]*[&(),]\)/\1xfree\2/g' \ > -e 's/\([ \t;,(]\)free$$/\1xfree/g' \ > -e '/^#line.*y.tab.c/d' \ > - -e "s/^\(#line.*\)`basename $<`/\1`echo $<|sed 's/\//\\\\\//g'`/" \ > < $@.tmp > $@ > rm -f $@.tmp > .l.c: >