From: Pedro Alves <palves@redhat.com>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: gdb-patches@sourceware.org, Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH] Don't munge yacc's #line directives
Date: Thu, 08 Jan 2015 14:06:00 -0000 [thread overview]
Message-ID: <54AE8ED4.70808@redhat.com> (raw)
In-Reply-To: <CA+C-WL_Ar9wpM9+kXd-pnyoz8KfXQKuyq2E1Wd3+KS4TT4Sv1Q@mail.gmail.com>
On 01/08/2015 12:48 PM, Patrick Palka wrote:
> Here is the upstream automake patch that is probably responsible for
> making the sed expression in question obsolete:
> http://git.savannah.gnu.org/cgit/automake.git/commit/lib/ylwrap?id=b6359a5f310160c8a4a2e8e8c0105408412ce400
I find that a bit confusing, since the comment says:
# We don't want the resulting debug information to point at
# an absolute srcdir.
(the upstream master version still has the comment, though
reformatted).
In any case, I think we've done due diligence already.
Could you update the commit log with the new findings and
references, and please also include an before/after example
of a #line line? With that, the patch is OK.
E.g., here's what I see, before/after your patch:
-#line 36 "/home/pedro/gdb/mygit/src/gdb//home/pedro/gdb/mygit/src/gdb/ada-exp.y"
+#line 36 "/home/pedro/gdb/mygit/src/gdb/ada-exp.y"
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-01-08 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 1:01 Patrick Palka
2015-01-08 12:02 ` Pedro Alves
2015-01-08 12:25 ` Patrick Palka
2015-01-08 12:49 ` Patrick Palka
2015-01-08 14:06 ` Pedro Alves [this message]
2015-01-09 22:23 ` Patrick Palka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AE8ED4.70808@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).