From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32072 invoked by alias); 8 Jan 2015 14:06:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32061 invoked by uid 89); 8 Jan 2015 14:06:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 08 Jan 2015 14:06:27 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t08E6OwM022150 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 8 Jan 2015 09:06:24 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t08E6D4Q004663; Thu, 8 Jan 2015 09:06:17 -0500 Message-ID: <54AE8ED4.70808@redhat.com> Date: Thu, 08 Jan 2015 14:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Patrick Palka CC: gdb-patches@sourceware.org, Jan Kratochvil Subject: Re: [PATCH] Don't munge yacc's #line directives References: <1420678878-14065-1-git-send-email-patrick@parcs.ath.cx> <54AE71D2.6020301@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00188.txt.bz2 On 01/08/2015 12:48 PM, Patrick Palka wrote: > Here is the upstream automake patch that is probably responsible for > making the sed expression in question obsolete: > http://git.savannah.gnu.org/cgit/automake.git/commit/lib/ylwrap?id=b6359a5f310160c8a4a2e8e8c0105408412ce400 I find that a bit confusing, since the comment says: # We don't want the resulting debug information to point at # an absolute srcdir. (the upstream master version still has the comment, though reformatted). In any case, I think we've done due diligence already. Could you update the commit log with the new findings and references, and please also include an before/after example of a #line line? With that, the patch is OK. E.g., here's what I see, before/after your patch: -#line 36 "/home/pedro/gdb/mygit/src/gdb//home/pedro/gdb/mygit/src/gdb/ada-exp.y" +#line 36 "/home/pedro/gdb/mygit/src/gdb/ada-exp.y" Thanks, Pedro Alves