From: Chen Gang S <gang.chen@sunrus.com.cn>
To: Pedro Alves <palves@redhat.com>, sellcey@imgtec.com
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Joel Brobecker <brobecker@adacore.com>,
gdb-patches@sourceware.org, Yao Qi <yao@codesourcery.com>
Subject: Re: [Patch] Fix build problem with system call in compile/compile.c
Date: Fri, 09 Jan 2015 10:46:00 -0000 [thread overview]
Message-ID: <54AFB275.9060803@sunrus.com.cn> (raw)
In-Reply-To: <54AFA92C.8010108@redhat.com>
On 1/9/15 18:10, Pedro Alves wrote:
> On 01/09/2015 03:54 AM, Chen Gang S wrote:
>>
>> Excuse me, I guess, I can not check in, welcome any other members help to
>> check in for me.
> I was going to apply it as is, but I recalled that the return
> of "system" is really a 'wait' status:
>
>> + if (system (zap))
>> + warning (_("Could not remove temporary directory %s"), dir);
>
> so I tweaked the patch accordingly, and pushed it, as below.
[...]
> - system (zap);
> + wstat = system (zap);
> + if (wstat == -1 || !WIFEXITED (wstat) || WEXITSTATUS (wstat) != 0)
> + warning (_("Could not remove temporary directory %s"), dir);
Oh, really it is. Thanks.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2015-01-09 10:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 0:44 Steve Ellcey
2015-01-06 3:09 ` Yao Qi
2015-01-06 4:16 ` Joel Brobecker
2015-01-06 16:04 ` Steve Ellcey
2015-01-07 4:14 ` Joel Brobecker
2015-01-07 18:36 ` Steve Ellcey
2015-01-07 19:01 ` Pedro Alves
2015-01-07 19:29 ` Maciej W. Rozycki
2015-01-07 19:35 ` Pedro Alves
2015-01-07 23:33 ` Maciej W. Rozycki
2015-01-08 21:12 ` Jan Kratochvil
2015-01-08 22:12 ` Steve Ellcey
2015-01-08 23:22 ` Pedro Alves
2015-01-09 0:10 ` Steve Ellcey
2015-01-09 3:47 ` Chen Gang S
2015-01-09 10:11 ` Pedro Alves
2015-01-09 10:46 ` Chen Gang S [this message]
2015-01-09 20:52 ` Chen Gang S
2015-01-09 21:53 ` Chen Gang S
2015-01-10 4:30 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AFB275.9060803@sunrus.com.cn \
--to=gang.chen@sunrus.com.cn \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=macro@linux-mips.org \
--cc=palves@redhat.com \
--cc=sellcey@imgtec.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).