From: Pedro Alves <palves@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
"'gdb-patches'" <gdb-patches@sourceware.org>
Cc: gpc@gnu.de
Subject: Re: gdb-patches RFA: Fix pascal behavior for class fields
Date: Fri, 09 Jan 2015 10:52:00 -0000 [thread overview]
Message-ID: <54AFB2E5.5080307@redhat.com> (raw)
In-Reply-To: <54ae911b.85e3440a.1d96.5ffdSMTPIN_ADDED_BROKEN@mx.google.com>
On 01/08/2015 02:15 PM, Pierre Muller wrote:
> For gpc mailing list:
> this email comes as a follow-up of this bug report
> https://sourceware.org/bugzilla/show_bug.cgi?id=17815
>
> The start of the thread can be found at:
> https://sourceware.org/ml/gdb-patches/2015-01/msg00164.html
>
> Pedro asked:
>>>> How about adding this to the test suite?
>>>
>>>
>>> The whole testsuite/gdb.pascal is almost empty,
>>> I never invested time to develop it :(
>>>
>>> At the time I started it, GPC (the GNU pascal compiler)
>>> was still active, but development apparently
>>> stopped since quite some time.
>>>
>>> I am unable to install GPC, which means that I cannot test it.
>>> Would a testsuite that supports only Free Pascal be acceptable?
>>
>> Do you actually mean, whether it's ok for a new
>> test (not test suite) to go in untested on GPC? It certainly is.
>> Better test on FPC than nowhere. :-)
> That is indeed what I meant.
>
>> AFAICS, the tests themselves don't really care which compiler
>> is in use other than for marking xfails; you just call
>> gdb_compile_pascal,
>> and that works with either. That's my impression from quickly
>> skimming testsuite/lib/pascal.exp.
>
> The problem is that GPC and Free Pascal support several
> pascal 'dialects'. But this requires command line options.
>
> The -Mobjfpc option is required for Free Pascal compiler
> to understand class type definition, but is rejected in default mode.
>
> I expect GNU GPC to also reject class in 'normal' mode...
> Maybe someone on the gpc mailing list knows if classes are supported
> by GPC and if it requires a special compiler option.
I'd suggest adding support for a new option to
gdb_compile_pascal, like "objfpc", so you'd compile
the test with:
if {[gdb_compile_pascal ... executable [list debug objfpc]] != "" } {
untested $testfile.exp
return -1
}
You'd teach fpc_compile about the new option:
proc fpc_compile {source dest type options} {
...
foreach i $options {
...
} elseif { $i == "objfpc" } {
append add_flags " -Mobjfpc"
}
...
}
Someone that cares about testing with GNU GPC would then
do the equivalent to gpc_compile, if anything is necessary.
If gpc simply fails to compile the test, it's no biggie,
as gdb_compile_pascal returns false, and the test is
skipped with "untested".
There may be a more generic and common name for the mode,
like "obj-pascal" or something, but I wouldn't know.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-01-09 10:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54ae4586.01e3440a.7b06.fffff844SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-08 10:48 ` [RFA] " Pedro Alves
2015-01-08 13:01 ` Pierre Muller
[not found] ` <54ae7f9f.c323460a.36ed.ffffff30SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-08 13:41 ` Pedro Alves
2015-01-08 14:15 ` gdb-patches RFA: " Pierre Muller
[not found] ` <54ae911b.85e3440a.1d96.5ffdSMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-09 10:52 ` Pedro Alves [this message]
2015-01-09 10:55 ` Pedro Alves
2015-01-09 16:16 ` [RFA 0/3] Fix pascal behavior for class fields with testcase Pierre Muller
2015-01-09 16:18 ` [RFA PATCH 2/3] Add debug-stabs debug-dwarf and class option for pascal compiler Pierre Muller
2015-02-04 23:37 ` [RFA 0/3 V4] Fix pascal behavior for class fields with testcase Pierre Muller
2015-02-15 6:59 ` PING " Pierre Muller
2015-04-07 20:06 ` PING^2 " Pierre Muller
[not found] ` <54e043b2.626ec20a.0c59.ffffaeacSMTPIN_ADDED_BROKEN@mx.google.com>
2015-04-20 6:00 ` PING " Doug Evans
2015-04-21 20:33 ` Pierre Muller
2015-01-09 16:16 ` [RFA PATCH 1/3] Remember the case pattern that allowed finding a field of this Pierre Muller
2015-01-23 7:30 ` [RFA PATCH 1/3 V3] " Pierre Muller
2015-02-04 23:37 ` [RFA PATCH 1/3 V4] " Pierre Muller
2015-01-09 16:18 ` [RFA PATCH 3/3] Testcase for pascal/17815 Pierre Muller
[not found] ` <54afff61.6790420a.0fa7.4f63SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-10 0:45 ` [RFA PATCH 2/3] Add debug-stabs debug-dwarf and class option for pascal compiler Doug Evans
2015-01-10 0:55 ` Pierre Muller
[not found] ` <54b07891.01b3c20a.2a7b.ffff9f96SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-10 21:23 ` Doug Evans
2015-01-14 15:04 ` [RFA PATCH 2/3 V2] Add "class" " Pierre Muller
[not found] ` <54b6858f.a287440a.5b61.ffff9ef0SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-22 12:49 ` Pedro Alves
2015-01-23 5:21 ` [RFA PATCH 2/3 V3] " Pierre Muller
2015-01-23 11:55 ` Pedro Alves
2015-02-04 23:37 ` [RFA PATCH 2/3 V4] " Pierre Muller
[not found] ` <54afff6b.ee8d440a.16ee.ffffb424SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-22 12:46 ` [RFA PATCH 3/3] Testcase for pascal/17815 Pedro Alves
2015-01-23 7:16 ` [RFA PATCH 3/3 V3] " Pierre Muller
2015-01-23 12:29 ` Pedro Alves
2015-02-04 23:37 ` [RFA PATCH 3/3 V4] " Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AFB2E5.5080307@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gpc@gnu.de \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).