From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6716 invoked by alias); 9 Jan 2015 20:52:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6697 invoked by uid 89); 9 Jan 2015 20:52:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: out1134-251.mail.aliyun.com Received: from out1134-251.mail.aliyun.com (HELO out1134-251.mail.aliyun.com) (42.120.134.251) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Jan 2015 20:51:58 +0000 X-Alimail-AntiSpam:AC=CONTINUE;BC=0.07724171|-1;FP=0|0|0|0|0|-1|-1|-1;HT=r41g03015;MF=gang.chen@sunrus.com.cn;PH=DS;RN=7;RT=7;SR=0; Received: from ShengShiZhuChengdeMacBook-Pro.local(mailfrom:gang.chen@sunrus.com.cn ip:223.72.65.45) by smtp.aliyun-inc.com(10.147.11.247); Sat, 10 Jan 2015 04:51:50 +0800 Message-ID: <54B04125.4050802@sunrus.com.cn> Date: Fri, 09 Jan 2015 20:52:00 -0000 From: Chen Gang S User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Pedro Alves , sellcey@imgtec.com CC: Jan Kratochvil , "Maciej W. Rozycki" , Joel Brobecker , gdb-patches@sourceware.org, Yao Qi Subject: Re: [Patch] Fix build problem with system call in compile/compile.c References: <20150106041615.GJ5445@adacore.com> <1420560255.15691.21.camel@ubuntu-sellcey> <20150107041351.GN5445@adacore.com> <1420655766.15691.44.camel@ubuntu-sellcey> <54AD8A76.9010702@redhat.com> <20150108211229.GA5634@host2.jankratochvil.net> <1420755123.2630.21.camel@ubuntu-sellcey> <54AF1118.2070707@redhat.com> <1420762209.2630.27.camel@ubuntu-sellcey> <54AF50E4.3080901@sunrus.com.cn> <54AFA92C.8010108@redhat.com> <54AFB275.9060803@sunrus.com.cn> In-Reply-To: <54AFB275.9060803@sunrus.com.cn> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00234.txt.bz2 On 1/9/15 18:50, Chen Gang S wrote: > On 1/9/15 18:10, Pedro Alves wrote: >> On 01/09/2015 03:54 AM, Chen Gang S wrote: >>> >>> Excuse me, I guess, I can not check in, welcome any other members help to >>> check in for me. >> I was going to apply it as is, but I recalled that the return >> of "system" is really a 'wait' status: >> >>> + if (system (zap)) >>> + warning (_("Could not remove temporary directory %s"), dir); >> >> so I tweaked the patch accordingly, and pushed it, as below. > [...] >> - system (zap); >> + wstat = system (zap); >> + if (wstat == -1 || !WIFEXITED (wstat) || WEXITSTATUS (wstat) != 0) >> + warning (_("Could not remove temporary directory %s"), dir); > > Oh, really it is. Thanks. > Excuse me, I am not quite familiar with the patch apply working flow for binutils/gdb, it seems each patch can only have one 'Signed-of-by' for it (do not like Linux kernel or QEMU, can have multiple 'Signed-of-by'). For me, this patch need multiple 'Signed-of-by': I start the patch, and Pedro Alves give a very necessary improvement (or it will introduce a new bug, which is not recognized quite obviously by others). If what I said above is correct, one way maybe, apply my original patch firstly, then apply the fix patch by Pedro Alves. I am not quite sure whether this way is suitable or not, though. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed