From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dje@google.com, gdb-patches@sourceware.org
Subject: Re: Building the 7.8.90 pretest on MinGW
Date: Thu, 22 Jan 2015 17:46:00 -0000 [thread overview]
Message-ID: <54C13764.2090109@redhat.com> (raw)
In-Reply-To: <83h9vivi7f.fsf@gnu.org>
On 01/22/2015 05:27 PM, Eli Zaretskii wrote:
>> Date: Thu, 22 Jan 2015 17:03:30 +0000
>> From: Pedro Alves <palves@redhat.com>
>> CC: dje@google.com, gdb-patches@sourceware.org
>>
>> No, I mean, start a shell buffer in emacs, start gdb within that,
>> and do "layout src".
>>
>> See https://sourceware.org/bugzilla/show_bug.cgi?id=17519.
>>
>> Could you try that?
>
> It says "TUI mode not allowed". (Tested in GDB 7.8.1 built with TUI,
> I don't have a newer binary where I type this.)
Ok, that's before my patch, but it means that isatty returned
false, so we're good after the patch too.
>
>>> Why would it? pipes fail the isatty test.
>>
>> Right. I recalled that Windows isatty returns true on all
>> sorts of character devices, like serial ports or the NUL device,
>> not just consoles, but confused pipes. Pipes are not one of
>> those. I see that gnulib has a isatty module that checks that
>> exactly -- it uses GetConsoleMode to make sure input is a real
>> console handle. We don't import that gnulib module presently, but
>> if we need that console check it sounds like importing that
>> module would be way to fix it.
>
> Fix what?
Let me rephrase it:
We don't import that gnulib module presently, but
if we need that console check it sounds like importing that
module would be way to add it.
Stress on the "IF".
> TUI doesn't need this fix. The only practical problem with
> MS runtime's isatty is that the null device doesn't fail it, but
> that's of a marginal importance for GDB, I think. That issue is
> important for filters and other batch-style programs where redirection
> to or from the null device is frequently used.
Since pipes already fail the isatty check, I agree it's of
marginal importance.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-01-22 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <announce.20150113122445.36DDE48E8A@joel.gnat.com>
2015-01-15 16:07 ` Eli Zaretskii
2015-01-15 19:49 ` Doug Evans
2015-01-19 17:48 ` Eli Zaretskii
2015-01-22 11:05 ` Pedro Alves
2015-01-22 16:09 ` Eli Zaretskii
2015-01-22 17:04 ` Pedro Alves
2015-01-22 17:27 ` Eli Zaretskii
2015-01-22 17:46 ` Pedro Alves [this message]
2015-01-22 18:30 ` Eli Zaretskii
2015-01-16 8:49 ` Eli Zaretskii
2015-01-20 18:27 ` Joel Brobecker
2015-01-20 18:36 ` Eli Zaretskii
2015-01-20 19:08 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C13764.2090109@redhat.com \
--to=palves@redhat.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).