From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30296 invoked by alias); 22 Jan 2015 17:46:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30230 invoked by uid 89); 22 Jan 2015 17:46:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 Jan 2015 17:46:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0MHkEo4024111 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Jan 2015 12:46:14 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0MHkCTW008756; Thu, 22 Jan 2015 12:46:13 -0500 Message-ID: <54C13764.2090109@redhat.com> Date: Thu, 22 Jan 2015 17:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Eli Zaretskii CC: dje@google.com, gdb-patches@sourceware.org Subject: Re: Building the 7.8.90 pretest on MinGW References: <83vbk82fkg.fsf@gnu.org> <83lhkyy84l.fsf@gnu.org> <54C0D965.9000305@redhat.com> <83ppa6vlv1.fsf@gnu.org> <54C12D62.7070801@redhat.com> <83h9vivi7f.fsf@gnu.org> In-Reply-To: <83h9vivi7f.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00605.txt.bz2 On 01/22/2015 05:27 PM, Eli Zaretskii wrote: >> Date: Thu, 22 Jan 2015 17:03:30 +0000 >> From: Pedro Alves >> CC: dje@google.com, gdb-patches@sourceware.org >> >> No, I mean, start a shell buffer in emacs, start gdb within that, >> and do "layout src". >> >> See https://sourceware.org/bugzilla/show_bug.cgi?id=17519. >> >> Could you try that? > > It says "TUI mode not allowed". (Tested in GDB 7.8.1 built with TUI, > I don't have a newer binary where I type this.) Ok, that's before my patch, but it means that isatty returned false, so we're good after the patch too. > >>> Why would it? pipes fail the isatty test. >> >> Right. I recalled that Windows isatty returns true on all >> sorts of character devices, like serial ports or the NUL device, >> not just consoles, but confused pipes. Pipes are not one of >> those. I see that gnulib has a isatty module that checks that >> exactly -- it uses GetConsoleMode to make sure input is a real >> console handle. We don't import that gnulib module presently, but >> if we need that console check it sounds like importing that >> module would be way to fix it. > > Fix what? Let me rephrase it: We don't import that gnulib module presently, but if we need that console check it sounds like importing that module would be way to add it. Stress on the "IF". > TUI doesn't need this fix. The only practical problem with > MS runtime's isatty is that the null device doesn't fail it, but > that's of a marginal importance for GDB, I think. That issue is > important for filters and other batch-style programs where redirection > to or from the null device is frequently used. Since pipes already fail the isatty check, I agree it's of marginal importance. Thanks, Pedro Alves