From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20372 invoked by alias); 23 Jan 2015 16:01:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20263 invoked by uid 89); 23 Jan 2015 16:01:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 23 Jan 2015 16:00:56 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 56.93.03307.09D12C45; Fri, 23 Jan 2015 11:08:16 +0100 (CET) Received: from [142.133.110.232] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.195.1; Fri, 23 Jan 2015 11:00:53 -0500 Message-ID: <54C27035.5030205@ericsson.com> Date: Fri, 23 Jan 2015 16:35:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Pedro Alves , CC: Subject: Re: [PATCH v2] Catch exception in value_rtti_indirect_type References: <1411174953-8930-1-git-send-email-simon.marchi@ericsson.com> <54809E38.3080606@redhat.com> <54821670.6020006@ericsson.com> <54C23FB2.90300@redhat.com> In-Reply-To: <54C23FB2.90300@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00652.txt.bz2 On 15-01-23 07:33 AM, Pedro Alves wrote: > On 12/05/2014 08:32 PM, Simon Marchi wrote: >=20 >> gdb/Changelog: >> >> * valops.c (value_rtti_indirect_type): Catch exception thrown by >> value_ind. >> >> gdb/testsuite/ChangeLog >> >> * gdb.mi/mi-var-list-children-invalid-grandchild.c: New file. >> * gdb.mi/mi-var-list-children-invalid-grandchild.exp: New file. >=20 > This is OK, thanks. >=20 >> +/* This testcase is part of GDB, the GNU debugger. >> + >> + Copyright 2014 Free Software Foundation, Inc. >=20 > Recall to update this to "2014-2015" before pushing. >=20 >> +++ b/gdb/testsuite/gdb.mi/mi-var-list-children-invalid-grandchild.exp >> @@ -0,0 +1,63 @@ >> +# Copyright 2014 Free Software Foundation, Inc. >> + >=20 > Please update these to "2014-2015" before pushing. >=20 > Thanks, > Pedro Alves Hmm I am now getting a /home/emaisin/src/binutils-gdb/gdb/valops.c:3625:13: error: =E2=80=98target= =E2=80=99 may be used uninitialized in this function [-Werror=3Dmaybe-unini= tialized] real_type =3D value_rtti_type (target, full, top, using_enc); Logically, target can't be uninitialized there because of the exception thr= ow. I would expect gcc to be smarter about it, since throw_error is marked as noreturn. I can obviously = fix it by assigning it to NULL at declaration time, but is there a better way of getting rid of the error = in these cases?