From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 467 invoked by alias); 23 Jan 2015 17:18:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 435 invoked by uid 89); 23 Jan 2015 17:18:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 23 Jan 2015 17:18:29 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0NHIMIV009256 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 23 Jan 2015 12:18:23 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0NHIKnb024321; Fri, 23 Jan 2015 12:18:21 -0500 Message-ID: <54C2825C.50302@redhat.com> Date: Sat, 24 Jan 2015 00:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Mark Wielaard CC: Stan Shebs , gdb-patches@sourceware.org Subject: Re: [PATCH] Use GCC5/DWARF5 DW_AT_noreturn to mark functions that don't return normally. References: <1417099980-31834-1-git-send-email-mjw@redhat.com> <5480696F.1060308@redhat.com> <1418122161.18974.42.camel@bordewijk.wildebeest.org> <548745FD.40000@earthlink.net> <1418210696.5011.10.camel@bordewijk.wildebeest.org> <548AC7C3.9020000@redhat.com> <1421366172.26117.29.camel@bordewijk.wildebeest.org> <54BFDCD8.9090709@redhat.com> <1422030805.4858.16.camel@bordewijk.wildebeest.org> In-Reply-To: <1422030805.4858.16.camel@bordewijk.wildebeest.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00660.txt.bz2 On 01/23/2015 04:33 PM, Mark Wielaard wrote: > On Wed, 2015-01-21 at 17:07 +0000, Pedro Alves wrote: >>> diff --git a/gdb/testsuite/gdb.base/noreturn.c b/gdb/testsuite/gdb.base/noreturn.c >>> new file mode 100644 >>> index 0000000..e39cf15 >>> --- /dev/null >>> +++ b/gdb/testsuite/gdb.base/noreturn.c >>> @@ -0,0 +1,13 @@ >> >> Please add a copyright header. Even though some of our old >> files don't have it, all new files should, even if the file >> is small (so that we don't have to recall adding it back >> if the file grows in future). > > Added. > Note that most .c files in gdb.base don't have such a header. Yeah, that's why I felt completed to explain why we add it for new files. Adding the header to old files now requires looking at the logs to know what would be the correct year range. That's a lot of boring work, so nobody ever does it. And that's exactly the work you've now spared someone in the future by adding the copyright header now. > Added the void. > Note most existing .c tests in gdb.base don't declare functions with > void arguments. Yes, a lot of old code in the testsuite doesn't follow the currently agreed rules for new files. Doesn't mean we need to keep repeating past mistakes though. See: https://sourceware.org/gdb/wiki/Internals%20GDB-Testsuite-Coding-Standards https://sourceware.org/gdb/wiki/GDBTestcaseCookbook It's just the usual problem of lacking manpower to go through the existing tests and update them. It'd be great to see that done (volunteers very much welcome!), but meanwhile, we try to avoid propagating bad idioms in new tests. Thanks, Pedro Alves