From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16437 invoked by alias); 27 Jan 2015 11:16:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16380 invoked by uid 89); 27 Jan 2015 11:16:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 27 Jan 2015 11:16:48 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0RBGj56002722 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 27 Jan 2015 06:16:45 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0RBGiSo017853; Tue, 27 Jan 2015 06:16:45 -0500 Message-ID: <54C7739C.1050701@redhat.com> Date: Tue, 27 Jan 2015 11:25:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 08/13] btrace: move and rename btrace-common References: <1416480444-9943-1-git-send-email-markus.t.metzger@intel.com> <1416480444-9943-9-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1416480444-9943-9-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00718.txt.bz2 On 11/20/2014 10:47 AM, Markus Metzger wrote: > diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c > index ebacd96..4ed9837 100644 > --- a/gdb/gdbserver/server.c > +++ b/gdb/gdbserver/server.c > @@ -30,7 +30,7 @@ > #endif > #include "gdb_vecs.h" > #include "gdb_wait.h" > -#include "btrace-common.h" > +#include "nat/x86-btrace.h" > #include "filestuff.h" > #include "tracepoint.h" > #include "dll.h" This still looks like layering violation this way. server.c should not really have x86 specific bits either. My original comment on v1 was: >> diff --git a/gdb/common/btrace-common.c b/gdb/common/btrace-common.c >> > index 90774a2..178ad35 100644 >> > --- a/gdb/common/btrace-common.c >> > +++ b/gdb/common/btrace-common.c >> > @@ -18,10 +18,47 @@ >> > along with this program. If not, see . */ >> > >> > #include "btrace-common.h" >> > +#include "nat/i386-cpuid.h" > Hm, this is a layering violation. > common/ files must not include nat/ files. > If btrace-common.c is only used by native code, then it should > itself be in nat/ too. So, what does btrace-common.h actually contain that server.c needs? "common" as a moniker doesn't really help much, as it doesn't really indicate what the code is about. Is it just common definitions that target-independent parts of gdb and/or gdbserver use? How about something like leaving those parts in common/ (bonus points of naming the file something more indicative or what is contains), and then the native bits, like the x86 probing would be put under nat/x86-btrace.h|c. Thanks, Pedro Alves