From: Pedro Alves <palves@redhat.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 01/13] btrace: add struct btrace_data
Date: Tue, 27 Jan 2015 11:29:00 -0000 [thread overview]
Message-ID: <54C773A9.6000105@redhat.com> (raw)
In-Reply-To: <1416480444-9943-2-git-send-email-markus.t.metzger@intel.com>
On 11/20/2014 10:47 AM, Markus Metzger wrote:
> diff --git a/gdb/common/btrace-common.c b/gdb/common/btrace-common.c
> new file mode 100644
> index 0000000..869d0cb
> --- /dev/null
> +++ b/gdb/common/btrace-common.c
> @@ -0,0 +1,82 @@
> +/* Copyright (C) 2014 Free Software Foundation, Inc.
> +
> + Contributed by Intel Corp. <markus.t.metzger@intel.com>
> +
> + This file is part of GDB.
> +
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; either version 3 of the License, or
> + (at your option) any later version.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program. If not, see <http://www.gnu.org/licenses/>. */
> +
> +#include "btrace-common.h"
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Include_Files
"All .c files under gdb/common/, gdb/nat/ and gdb/target/ must include common-defs.h
as their first non-comment line."
> diff --git a/gdb/common/btrace-common.h b/gdb/common/btrace-common.h
> index 339e684..27e7a95 100644
> --- a/gdb/common/btrace-common.h
> +++ b/gdb/common/btrace-common.h
> @@ -26,6 +26,7 @@
> inferior. For presentation purposes, the branch trace is represented as a
> list of sequential control-flow blocks, one such list per thread. */
>
> +#include "common-defs.h"
> #include "vec.h"
"No .h file should include defs.h, server.h or common-defs.h."
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-01-27 11:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 10:47 [PATCH v2 00/13] record btrace: prepare for a new trace format Markus Metzger
2014-11-20 10:47 ` [PATCH v2 02/13] btrace: add format argument to supports_btrace Markus Metzger
2014-11-20 10:47 ` [PATCH v2 07/13] btrace: extend struct btrace_insn Markus Metzger
2014-11-20 10:47 ` [PATCH v2 09/13] btrace: identify cpu Markus Metzger
2014-11-20 10:47 ` [PATCH v2 10/13] btrace: use the new cpu identifier Markus Metzger
2014-11-20 10:47 ` [PATCH v2 04/13] record btrace: add configuration struct Markus Metzger
2014-11-20 10:47 ` [PATCH v2 08/13] btrace: move and rename btrace-common Markus Metzger
2015-01-27 11:25 ` Pedro Alves
2015-01-28 17:58 ` Metzger, Markus T
2014-11-20 10:47 ` [PATCH v2 03/13] btrace, linux: add perf event buffer abstraction Markus Metzger
2015-01-27 15:31 ` Pedro Alves
2015-01-27 18:14 ` Metzger, Markus T
2015-01-27 18:15 ` Pedro Alves
2015-01-28 16:50 ` Metzger, Markus T
2014-11-20 10:47 ` [PATCH v2 12/13] configure: check for libipt Markus Metzger
2014-11-20 10:47 ` [PATCH v2 11/13] record-btrace: indicate gaps Markus Metzger
2014-11-20 17:32 ` Metzger, Markus T
2014-11-20 17:36 ` Eli Zaretskii
2014-11-20 10:47 ` [PATCH v2 05/13] record-btrace: add bts buffer size configuration option Markus Metzger
2014-11-20 16:25 ` Eli Zaretskii
2014-11-20 10:47 ` [PATCH v2 01/13] btrace: add struct btrace_data Markus Metzger
2015-01-27 11:29 ` Pedro Alves [this message]
2014-11-20 10:47 ` [PATCH v2 06/13] btrace: update btrace_compute_ftrace parameters Markus Metzger
2014-11-20 10:47 ` [PATCH v2 13/13] [wip] btrace: support Intel(R) Processor Trace Markus Metzger
2014-11-20 16:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C773A9.6000105@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).