From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17286 invoked by alias); 27 Jan 2015 11:17:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16488 invoked by uid 89); 27 Jan 2015 11:17:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 27 Jan 2015 11:17:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0RBGwUc024271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 27 Jan 2015 06:16:59 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0RBGvBL017889; Tue, 27 Jan 2015 06:16:58 -0500 Message-ID: <54C773A9.6000105@redhat.com> Date: Tue, 27 Jan 2015 11:29:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 01/13] btrace: add struct btrace_data References: <1416480444-9943-1-git-send-email-markus.t.metzger@intel.com> <1416480444-9943-2-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1416480444-9943-2-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00719.txt.bz2 On 11/20/2014 10:47 AM, Markus Metzger wrote: > diff --git a/gdb/common/btrace-common.c b/gdb/common/btrace-common.c > new file mode 100644 > index 0000000..869d0cb > --- /dev/null > +++ b/gdb/common/btrace-common.c > @@ -0,0 +1,82 @@ > +/* Copyright (C) 2014 Free Software Foundation, Inc. > + > + Contributed by Intel Corp. > + > + This file is part of GDB. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#include "btrace-common.h" https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Include_Files "All .c files under gdb/common/, gdb/nat/ and gdb/target/ must include common-defs.h as their first non-comment line." > diff --git a/gdb/common/btrace-common.h b/gdb/common/btrace-common.h > index 339e684..27e7a95 100644 > --- a/gdb/common/btrace-common.h > +++ b/gdb/common/btrace-common.h > @@ -26,6 +26,7 @@ > inferior. For presentation purposes, the branch trace is represented as a > list of sequential control-flow blocks, one such list per thread. */ > > +#include "common-defs.h" > #include "vec.h" "No .h file should include defs.h, server.h or common-defs.h." Thanks, Pedro Alves