From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30913 invoked by alias); 28 Jan 2015 15:53:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28986 invoked by uid 89); 28 Jan 2015 15:53:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: homiemail-a57.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a57.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jan 2015 15:53:47 +0000 Received: from homiemail-a57.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a57.g.dreamhost.com (Postfix) with ESMTP id 9E2F8208070; Wed, 28 Jan 2015 07:53:45 -0800 (PST) Received: from redwood.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a57.g.dreamhost.com (Postfix) with ESMTPSA id 77AF1208063; Wed, 28 Jan 2015 07:53:35 -0800 (PST) Message-ID: <54C905FE.6020207@eagerm.com> Date: Wed, 28 Jan 2015 20:43:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Chen Gang S , gdb-patches@sourceware.org CC: binutils@sourceware.org Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv(). References: <54C8CBC8.90102@sunrus.com.cn> In-Reply-To: <54C8CBC8.90102@sunrus.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00735.txt.bz2 On 01/28/15 03:45, Chen Gang S wrote: > buildargv() and freeargv() are pairs, so need be sure of them always > paired to avoid memory leak. > > 2015-01-28 Chen Gang > > * common/sim-options.c (sim_args_command): Call freeargv() when > failure occurs. > * mcore/interp.c (sim_do_command): Call freeargv() before return. > * microblaze/interp.c (sim_do_command): Call freeargv() before > return. OK for Microblaze. There appear to be other places where buildargv() is not followed by freeargv(). See sim/common/run.c. There may be others. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077