From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13079 invoked by alias); 29 Jan 2015 05:01:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13047 invoked by uid 89); 29 Jan 2015 05:01:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: out1134-202.mail.aliyun.com Received: from out1134-202.mail.aliyun.com (HELO out1134-202.mail.aliyun.com) (42.120.134.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Jan 2015 05:01:20 +0000 X-Alimail-AntiSpam:AC=CONTINUE;BC=0.1248468|-1;FP=0|0|0|0|0|-1|-1|-1;HT=r41g03007;MF=gang.chen@sunrus.com.cn;PH=DS;RN=2;RT=2;SR=0; Received: from ShengShiZhuChengdeMacBook-Pro.local(mailfrom:gang.chen@sunrus.com.cn ip:124.127.118.42) by smtp.aliyun-inc.com(10.147.11.252); Thu, 29 Jan 2015 13:01:09 +0800 Message-ID: <54C9C063.8090307@sunrus.com.cn> Date: Thu, 29 Jan 2015 07:28:00 -0000 From: Chen Gang S User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv(). References: <54C8CBC8.90102@sunrus.com.cn> <20150129044911.GB5193@adacore.com> In-Reply-To: <20150129044911.GB5193@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00748.txt.bz2 On 1/29/15 12:49, Joel Brobecker wrote: > [binutils does not need to be copied in this case, as you're only > touching files in the simulator, which is part of the GDB project] > >> 2015-01-28 Chen Gang >> >> * common/sim-options.c (sim_args_command): Call freeargv() when >> failure occurs. >> * mcore/interp.c (sim_do_command): Call freeargv() before return. >> * microblaze/interp.c (sim_do_command): Call freeargv() before >> return. > > Small procedural request, Chen. Those 3 changes are pretty much > independent, so it's highly preferable to submit them separately. > This has a number of advantages: We can review each one of them > individually, with possibly different reviewers, and that makes > tracking of which part has been reviewed a lot easier. Also, by > having them submitted separately, you can have one patch per piece, > which means that if one patch turns out to be incorrect, we can > easily revert just that patch using git, rather than doing a semi- > revert by hand. > OK, thanks. I shall send 3 separated patches for it within this month. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed